From: zeertzjq <zeertzjq@outlook.com>
Date: Sat, 11 Mar 2023 16:18:51 +0000 (+0000)
Subject: patch 9.0.1401: condition is always true
X-Git-Tag: v9.0.1401
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c481ad38f05c9f759ca7fd01a54c78acad794e85;p=vim

patch 9.0.1401: condition is always true

Problem:    Condition is always true.
Solution:   Remove the condition. (closes #12139)
---

diff --git a/src/eval.c b/src/eval.c
index c82e7046d..37b50c38e 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -6885,20 +6885,17 @@ handle_subscript(
 		*arg = skipwhite(p + 2);
 	    else
 		*arg = p + 2;
-	    if (ret == OK)
+	    if (VIM_ISWHITE(**arg))
 	    {
-		if (VIM_ISWHITE(**arg))
-		{
-		    emsg(_(e_no_white_space_allowed_before_parenthesis));
-		    ret = FAIL;
-		}
-		else if ((**arg == '{' && !in_vim9script()) || **arg == '(')
-		    // expr->{lambda}() or expr->(lambda)()
-		    ret = eval_lambda(arg, rettv, evalarg, verbose);
-		else
-		    // expr->name()
-		    ret = eval_method(arg, rettv, evalarg, verbose);
+		emsg(_(e_no_white_space_allowed_before_parenthesis));
+		ret = FAIL;
 	    }
+	    else if ((**arg == '{' && !in_vim9script()) || **arg == '(')
+		// expr->{lambda}() or expr->(lambda)()
+		ret = eval_lambda(arg, rettv, evalarg, verbose);
+	    else
+		// expr->name()
+		ret = eval_method(arg, rettv, evalarg, verbose);
 	}
 	// "." is ".name" lookup when we found a dict or when evaluating and
 	// scriptversion is at least 2, where string concatenation is "..".
diff --git a/src/version.c b/src/version.c
index b1d88f485..0265c47a9 100644
--- a/src/version.c
+++ b/src/version.c
@@ -695,6 +695,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1401,
 /**/
     1400,
 /**/