From: Tim Peters <tim.peters@gmail.com>
Date: Thu, 8 May 2003 18:13:59 +0000 (+0000)
Subject: Leading "C:" no longer hardcoded in the default installation directory.
X-Git-Tag: v2.3c1~799
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c4607dadce95073361a091d2c4cef42de5be44a3;p=python

Leading "C:" no longer hardcoded in the default installation directory.
After removing that, two testers on machines where C: is not the system
drive reported that the installer suggested their system drive instead
of C:, and that's what they wanted it to do.
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 98feacc8a1..01c0ba6b47 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -62,6 +62,16 @@ Tests
 Windows
 -------
 
+- The installer always suggested that Python be installed on the C:
+  drive, due to a hardcoded "C:" generated by the Wise installation
+  wizard.  People with machines where C: is not the system drive
+  usually want Python installed on whichever drive is their system drive
+  instead.  We removed the hardcoded "C:", and two testers on machines
+  where C: is not the system drive report that the installer now
+  suggests their system drive.  Note that you can always select the
+  directory you want in the "Select Destination Directory" dialog --
+  that's what it's for.
+
 Mac
 ---
 
diff --git a/PCbuild/python20.wse b/PCbuild/python20.wse
index 64c3ef00d3..90ecf25331 100644
--- a/PCbuild/python20.wse
+++ b/PCbuild/python20.wse
@@ -203,11 +203,20 @@ end
 item: End Block
 end
 item: Remark
-  Text=Note from Tim:  doesn't seem to be a way to get the true boot drive, the Wizard hardcodes "C".
+  Text=Note from Tim:  The Wizard hardcod "C:" at the start of the replacement text for MAINDIR.
+end
+item: Remark
+  Text=That's not appropriate if the system drive doesn't happen to be C:.
+end
+item: Remark
+  Text=I removed the "C:", and that did the right thing for two people who tested it on non-C: machines,
+end
+item: Remark
+  Text=but it's unclear whether it will always do the right thing.
 end
 item: Set Variable
   Variable=MAINDIR
-  Value=C:\%MAINDIR%
+  Value=\%MAINDIR%
   Flags=00001100
 end
 item: Remark