From: Birunthan Mohnathas <birunthan@mohanathas.com>
Date: Mon, 12 Mar 2012 16:56:08 +0000 (+0200)
Subject: Fixed memory leak of FrameFactory singleton.
X-Git-Tag: v1.8beta~26
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c4163a26e805bdec9a79b899bc0277d5501cb450;p=taglib

Fixed memory leak of FrameFactory singleton.
---

diff --git a/taglib/mpeg/id3v2/id3v2framefactory.cpp b/taglib/mpeg/id3v2/id3v2framefactory.cpp
index b6bc34a5..da9c8018 100644
--- a/taglib/mpeg/id3v2/id3v2framefactory.cpp
+++ b/taglib/mpeg/id3v2/id3v2framefactory.cpp
@@ -73,9 +73,8 @@ FrameFactory *FrameFactory::factory = 0;
 
 FrameFactory *FrameFactory::instance()
 {
-  if(!factory)
-    factory = new FrameFactory;
-  return factory;
+  static FrameFactory factory;
+  return &factory;
 }
 
 Frame *FrameFactory::createFrame(const ByteVector &data, bool synchSafeInts) const