From: Christophe Jaillet Date: Sun, 29 Nov 2015 16:06:28 +0000 (+0000) Subject: Silent a sparse Warning. X-Git-Tag: 2.5.0-alpha~2579 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c3bc5ac55242098649abaafb53ceb3f2c4007f70;p=apache Silent a sparse Warning. cid->ecb->lpszLogData can not be NULL. It is defined in mod_isapi.h as: typedef struct EXTENSION_CONTROL_BLOCK { ... char lpszLogData[80]; ... git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1717086 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/modules/arch/win32/mod_isapi.c b/modules/arch/win32/mod_isapi.c index ec0d35e74f..66cc8da69e 100644 --- a/modules/arch/win32/mod_isapi.c +++ b/modules/arch/win32/mod_isapi.c @@ -1582,9 +1582,10 @@ static apr_status_t isapi_handler (request_rec *r) rv = (*isa->HttpExtensionProc)(cid->ecb); /* Check for a log message - and log it */ - if (cid->ecb->lpszLogData && *cid->ecb->lpszLogData) + if (*cid->ecb->lpszLogData) { ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(02113) "%s: %s", r->filename, cid->ecb->lpszLogData); + } switch(rv) { case 0: /* Strange, but MS isapi accepts this as success */