From: Anastasia Stulova Date: Thu, 2 May 2019 14:40:40 +0000 (+0000) Subject: [OpenCL] Deduce static data members to __global addr space. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c38febbb182950aea135ddba6520186103110074;p=clang [OpenCL] Deduce static data members to __global addr space. Similarly to static variables in OpenCL, static class data members should be deduced to __global addr space. Differential Revision: https://reviews.llvm.org/D61304 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@359789 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Sema/SemaType.cpp b/lib/Sema/SemaType.cpp index 32e57eb925..3b25595a33 100644 --- a/lib/Sema/SemaType.cpp +++ b/lib/Sema/SemaType.cpp @@ -7308,8 +7308,10 @@ static void deduceOpenCLImplicitAddrSpace(TypeProcessingState &State, // otherwise it will fail some sema check. IsFuncReturnType || IsFuncType || // Do not deduce addr space for member types of struct, except the pointee - // type of a pointer member type. - (D.getContext() == DeclaratorContext::MemberContext && !IsPointee) || + // type of a pointer member type or static data members. + (D.getContext() == DeclaratorContext::MemberContext && + (!IsPointee && + D.getDeclSpec().getStorageClassSpec() != DeclSpec::SCS_static)) || // Do not deduce addr space for types used to define a typedef and the // typedef itself, except the pointee type of a pointer type which is used // to define the typedef. diff --git a/test/SemaOpenCLCXX/address-space-deduction.cl b/test/SemaOpenCLCXX/address-space-deduction.cl new file mode 100644 index 0000000000..d6dcc853a6 --- /dev/null +++ b/test/SemaOpenCLCXX/address-space-deduction.cl @@ -0,0 +1,12 @@ +//RUN: %clang_cc1 %s -cl-std=c++ -pedantic -ast-dump -verify + +//expected-no-diagnostics + +//CHECK: |-VarDecl foo {{.*}} 'const __global int' constexpr cinit +constexpr int foo = 0; + +class c { +public: + //CHECK: `-VarDecl {{.*}} foo2 'const __global int' static constexpr cinit + static constexpr int foo2 = 0; +};