From: Christian Göttsche <cgzones@googlemail.com>
Date: Fri, 6 Sep 2019 15:54:57 +0000 (+0200)
Subject: fix resource leak in db_getinterfaceinfo
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c37fca1d7cdc7f6a11e132516f2d1b888d7192bb;p=vnstat

fix resource leak in db_getinterfaceinfo

if 'ifaceidin' gets initialized but it's length is 0, it is not freed

found by Coverity
---

diff --git a/src/dbsql.c b/src/dbsql.c
index 12fd51b..c559637 100644
--- a/src/dbsql.c
+++ b/src/dbsql.c
@@ -616,6 +616,7 @@ int db_getinterfaceinfo(const char *iface, interfaceinfo *info)
 	} else {
 		ifaceidin = db_getinterfaceidin(iface);
 		if (ifaceidin == NULL || strlen(ifaceidin) < 1) {
+			free(ifaceidin);
 			return 0;
 		}
 		sqlite3_snprintf(512, sql, "select \"%q\", NULL, max(active), max(strftime('%%s', created, 'utc')), min(strftime('%%s', updated, 'utc')), 0, 0, sum(rxtotal), sum(txtotal) from interface where id in (%q)", iface, ifaceidin);