From: Thomas Punt <tpunt@hotmail.co.uk>
Date: Wed, 11 Nov 2015 22:13:57 +0000 (+0000)
Subject: Remove useless check in substr()
X-Git-Tag: php-7.1.0alpha1~748^2~7^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c37890062d23093f844cceb4e6b619bb510eb793;p=php

Remove useless check in substr()

This check (if the start position is greater than the string length) is already performed on line 2399
---

diff --git a/ext/standard/string.c b/ext/standard/string.c
index 3d5b76caa2..3922ff497d 100644
--- a/ext/standard/string.c
+++ b/ext/standard/string.c
@@ -2426,10 +2426,6 @@ PHP_FUNCTION(substr)
 		}
 	}
 
-	if (f > (zend_long)ZSTR_LEN(str)) {
-		RETURN_FALSE;
-	}
-
 	if ((f + l) > (zend_long)ZSTR_LEN(str)) {
 		l = ZSTR_LEN(str) - f;
 	}