From: Matthew Ahrens <mahrens@delphix.com>
Date: Thu, 4 Oct 2018 20:10:10 +0000 (-0700)
Subject: Add codecheck make target
X-Git-Tag: zfs-0.8.0-rc2~73
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c23f8d4829ce50e92b60f69b3b80e5301db476b2;p=zfs

Add codecheck make target

We'd like to have tooling that verifies code style, while ignoring the
commit message.  For example, code does not need to be signed off in
order to be tested.  Current workarounds are to run `git checkstyle` and
ignore the commit message errors, or to run `make cstyle shellcheck
flake8 mancheck testscheck`, and make sure that list stays updated.

Solution is to add a new make target, `codecheck` which does all the
code checks.  `checkstyle` is now simply `codecheck` + `commitcheck`.

Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #7985
---

diff --git a/Makefile.am b/Makefile.am
index f2cd574a9..61bf9e235 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -61,7 +61,9 @@ install-data-hook:
 	ln -fs zfs.release spl.release
 endif
 
-checkstyle: cstyle shellcheck flake8 commitcheck mancheck testscheck
+codecheck: cstyle shellcheck flake8 mancheck testscheck
+
+checkstyle: codecheck commitcheck
 
 commitcheck:
 	@if git rev-parse --git-dir > /dev/null 2>&1; then \