From: Georg Brandl <georg@python.org>
Date: Sat, 19 Jan 2008 18:02:46 +0000 (+0000)
Subject: #1782: don't leak in error case in PyModule_AddXxxConstant. Patch by Hrvoje Nikšić.
X-Git-Tag: v2.6a1~537
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c211a0a00b286188b8a4182e924511bdcbb85cda;p=python

#1782: don't leak in error case in PyModule_AddXxxConstant. Patch by Hrvoje Nikšić.
---

diff --git a/Python/modsupport.c b/Python/modsupport.c
index 1aa3df2852..d54158f212 100644
--- a/Python/modsupport.c
+++ b/Python/modsupport.c
@@ -621,11 +621,23 @@ PyModule_AddObject(PyObject *m, const char *name, PyObject *o)
 int 
 PyModule_AddIntConstant(PyObject *m, const char *name, long value)
 {
-	return PyModule_AddObject(m, name, PyInt_FromLong(value));
+	PyObject *o = PyInt_FromLong(value);
+	if (!o)
+		return -1;
+	if (PyModule_AddObject(m, name, o) == 0)
+		return 0;
+	Py_DECREF(o);
+	return -1;
 }
 
 int 
 PyModule_AddStringConstant(PyObject *m, const char *name, const char *value)
 {
-	return PyModule_AddObject(m, name, PyString_FromString(value));
+	PyObject *o = PyString_FromString(value);
+	if (!o)
+		return -1;
+	if (PyModule_AddObject(m, name, o) == 0)
+		return 0;
+	Py_DECREF(o);
+	return -1;
 }