From: cjlin Date: Mon, 11 Oct 2010 05:24:38 +0000 (+0000) Subject: add a comment in l1r_lr indicating that X-Git-Tag: v180~18 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c206129cb883df35c17513afd31228c5313188ba;p=liblinear add a comment in l1r_lr indicating that approx line search condition works only if xij>=0 --- diff --git a/linear.cpp b/linear.cpp index c6f7168..cff1188 100644 --- a/linear.cpp +++ b/linear.cpp @@ -1494,6 +1494,7 @@ static void solve_l1r_lr( { cond = fabs(w[j]+d)-fabs(w[j]) - sigma*delta; + // approx line search works only if xij>=0 if(x_min >= 0) { double tmp = exp(d*xj_max[j]);