From: Craig Small <csmall@enc.com.au>
Date: Sat, 9 Jul 2016 04:11:06 +0000 (+1000)
Subject: build-sys: Make check programs before check
X-Git-Tag: v4.0.0~832
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c1aa5725b2b93e85350397c4240ad56a39426d7b;p=procps-ng

build-sys: Make check programs before check

For some unknown reason, check_PROGRAMS are not built before check.
They are built before recheck and after check, which isn't very
useful.

This means any tests by dejagnu that need those programs will fail.
On my console I get a build error, the CI merrily reports the error
but considers the build OK; go figure.

The kludge adds check_PROGRAMS to be a dependency to check.
Note, TESTS don't need to be included in this, because they are
properly compliled after the dejagnu tests but before they are
run.
---

diff --git a/Makefile.am b/Makefile.am
index 52d4fbaa..4d316855 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -252,6 +252,9 @@ ps_pscommand_SOURCES =  \
 	lib/signals.c
 
 
+# Note sure why this is needed but it breaks without it
+check: $(check_PROGRAMS)
+
 # lib/test_* binaries
 check_PROGRAMS = \
 	lib/test_strutils \