From: Alex Brachet <alexbrachetmialot@gmail.com>
Date: Fri, 19 Jul 2019 02:31:21 +0000 (+0000)
Subject: [test] [llvm-objcopy] Fix broken test case
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c1a4a73e9819fc74ec020bc766a3ae268972e437;p=llvm

[test] [llvm-objcopy] Fix broken test case

Summary: The test case added in D62718 did not work unless the user was root because write bits were not set for the output file. This change uses only permissions with user write (0200) to ensure tests pass regardless of the users permissions.

Reviewers: jhenderson, rupprecht, MaskRay, espindola, alexshap

Reviewed By: MaskRay

Subscribers: emaste, arichardson, jakehehrlich, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64302

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@366527 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/test/tools/llvm-objcopy/ELF/respect-umask.test b/test/tools/llvm-objcopy/ELF/respect-umask.test
index 03f97cdae9b..f4d30990561 100644
--- a/test/tools/llvm-objcopy/ELF/respect-umask.test
+++ b/test/tools/llvm-objcopy/ELF/respect-umask.test
@@ -9,18 +9,25 @@
 # RUN: touch %t
 # RUN: chmod 0755 %t
 # RUN: ls -l %t | cut -f 1 -d ' ' > %t.0755
-# RUN: chmod 0500 %t
-# RUN: ls -l %t | cut -f 1 -d ' ' > %t.0500
-# RUN: chmod 0555 %t
-# RUN: ls -l %t | cut -f 1 -d ' ' > %t.0555
+# RUN: chmod 0600 %t
+# RUN: ls -l %t | cut -f 1 -d ' ' > %t.0600
+# RUN: chmod 0655 %t
+# RUN: ls -l %t | cut -f 1 -d ' ' > %t.0655
 
-# RUN: rm -f %t; yaml2obj %s -o %t
+# RUN: yaml2obj %s -o %t
 
 # RUN: umask 0022
 # RUN: chmod 0777 %t
-# RUN: rm -f %t1; llvm-objcopy %t %t1
-# RUN: ls -l %t1 | cut -f 1 -d ' ' > %t1.perms
-# RUN: cmp %t1.perms %t.0755
+# RUN: llvm-objcopy %t %t1
+# RUN: ls -l %t1 | cut -f 1 -d ' ' | cmp - %t.0755
+
+# RUN: umask 0177
+# RUN: llvm-objcopy %t %t2
+# RUN: ls -l %t2 | cut -f 1 -d ' ' | cmp - %t.0600
+
+# RUN: umask 0122
+# RUN: llvm-objcopy %t %t3
+# RUN: ls -l %t3 | cut -f 1 -d ' ' | cmp - %t.0655
 
 --- !ELF
 FileHeader: