From: cristy <urban-warrior@git.imagemagick.org>
Date: Sun, 9 Mar 2014 14:54:05 +0000 (+0000)
Subject: (no commit message)
X-Git-Tag: 7.0.1-0~2598
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c1712b2884438ecab79dd868f892aa781275f055;p=imagemagick

---

diff --git a/MagickCore/matrix.c b/MagickCore/matrix.c
index 83f7928bf..e6db4c687 100644
--- a/MagickCore/matrix.c
+++ b/MagickCore/matrix.c
@@ -68,7 +68,8 @@ struct _MatrixInfo
     length;
 
   MagickBooleanType
-    mapped;
+    mapped,
+    synchronize;
 
   char
     path[MaxTextExtent];
@@ -94,7 +95,7 @@ struct _MatrixInfo
 %                                                                             %
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %
-%  AcquireMatrixInfo() allocates the MatrixInfo structure.
+%  AcquireMatrixInfo() allocates the ImageInfo structure.
 %
 %  The format of the AcquireMatrixInfo method is:
 %
@@ -112,9 +113,96 @@ struct _MatrixInfo
 %    o exception: return any errors or warnings in this structure.
 %
 */
+
+static inline MagickSizeType MagickMin(const MagickSizeType x,
+  const MagickSizeType y)
+{
+  if (x < y)
+    return(x);
+  return(y);
+}
+
+#if defined(SIGBUS)
+static void MatrixSignalHandler(int status)
+{
+  ThrowFatalException(CacheFatalError,"UnableToExtendMatrixCache");
+}
+#endif
+
+static inline MagickOffsetType WriteMatrixElements(
+  const MatrixInfo *restrict matrix_info,const MagickOffsetType offset,
+  const MagickSizeType length,const unsigned char *restrict buffer)
+{
+  register MagickOffsetType
+    i;
+
+  ssize_t
+    count;
+
+#if !defined(MAGICKCORE_HAVE_PWRITE)
+  if (lseek(matrix_info->file,offset,SEEK_SET) < 0)
+    return((MagickOffsetType) -1);
+#endif
+  count=0;
+  for (i=0; i < (MagickOffsetType) length; i+=count)
+  {
+#if !defined(MAGICKCORE_HAVE_PWRITE)
+    count=write(matrix_info->file,buffer+i,(size_t) MagickMin(length-i,
+      (MagickSizeType) SSIZE_MAX));
+#else
+    count=pwrite(matrix_info->file,buffer+i,(size_t) MagickMin(length-i,
+      (MagickSizeType) SSIZE_MAX),(off_t) (offset+i));
+#endif
+    if (count <= 0)
+      {
+        count=0;
+        if (errno != EINTR)
+          break;
+      }
+  }
+  return(i);
+}
+
+static MagickBooleanType SetMatrixExtent(MatrixInfo *restrict matrix_info,
+  MagickSizeType length)
+{
+  MagickOffsetType
+    count,
+    extent,
+    offset;
+
+  if (length != (MagickSizeType) ((MagickOffsetType) length))
+    return(MagickFalse);
+  offset=(MagickOffsetType) lseek(matrix_info->file,0,SEEK_END);
+  if (offset < 0)
+    return(MagickFalse);
+  if ((MagickSizeType) offset >= length)
+    return(MagickTrue);
+  extent=(MagickOffsetType) length-1;
+  count=WriteMatrixElements(matrix_info,extent,1,(const unsigned char *) "");
+#if defined(MAGICKCORE_HAVE_POSIX_FALLOCATE)
+  if (matrix_info->synchronize != MagickFalse)
+    {
+      int
+        status;
+
+      status=posix_fallocate(matrix_info->file,offset+1,extent-offset);
+      if (status != 0)
+        return(MagickFalse);
+    }
+#endif
+#if defined(SIGBUS)
+  (void) signal(SIGBUS,MatrixSignalHandler);
+#endif
+  return(count != (MagickOffsetType) 1 ? MagickFalse : MagickTrue);
+}
+
 MagickExport MatrixInfo *AcquireMatrixInfo(const size_t columns,
   const size_t rows,const size_t stride,ExceptionInfo *exception)
 {
+  char
+    *synchronize;
+
   MagickBooleanType
     status;
 
@@ -129,6 +217,12 @@ MagickExport MatrixInfo *AcquireMatrixInfo(const size_t columns,
   matrix_info->columns=columns;
   matrix_info->rows=rows;
   matrix_info->stride=stride;
+  synchronize=GetEnvironmentValue("MAGICK_SYNCHRONIZE");
+  if (synchronize != (const char *) NULL)
+    {
+      matrix_info->synchronize=IsStringTrue(synchronize);
+      synchronize=DestroyString(synchronize);
+    }
   matrix_info->length=(MagickSizeType) columns*rows*stride;
   if (matrix_info->columns != (size_t) (matrix_info->length/rows/stride))
     {
@@ -144,6 +238,7 @@ MagickExport MatrixInfo *AcquireMatrixInfo(const size_t columns,
       status=AcquireMagickResource(MemoryResource,matrix_info->length);
       if (status != MagickFalse)
         {
+          matrix_info->mapped=MagickFalse;
           matrix_info->elements=AcquireMagickMemory((size_t)
             matrix_info->length);
           if (matrix_info->elements == NULL)
@@ -174,7 +269,7 @@ MagickExport MatrixInfo *AcquireMatrixInfo(const size_t columns,
       status=AcquireMagickResource(MapResource,matrix_info->length);
       if (status != MagickFalse)
         {
-          status=ResetMatrixInfo(matrix_info);
+          status=SetMatrixExtent(matrix_info,matrix_info->length);
           if (status != MagickFalse)
             {
               matrix_info->elements=(void *) MapBlob(matrix_info->file,IOMode,0,
@@ -548,54 +643,37 @@ MagickExport size_t GetMatrixColumns(const MatrixInfo *matrix_info)
 %
 */
 
-static inline size_t MagickMin(const size_t x,const size_t y)
-{
-  if (x < y)
-    return(x);
-  return(y);
-}
-
-static inline ssize_t ReadMatrixInfo(const MatrixInfo *matrix_info,
-  const MagickOffsetType offset,const size_t length,unsigned char *buffer)
+static inline MagickOffsetType ReadMatrixElements(
+  const MatrixInfo *restrict matrix_info,const MagickOffsetType offset,
+  const MagickSizeType length,unsigned char *restrict buffer)
 {
-  register ssize_t
+  register MagickOffsetType
     i;
 
   ssize_t
     count;
 
-#if !defined(MAGICKCORE_HAVE_PPREAD)
-#if defined(MAGICKCORE_OPENMP_SUPPORT)
-  #pragma omp critical (MagickCore_ReadMatrixInfo)
+#if !defined(MAGICKCORE_HAVE_PREAD)
+  if (lseek(matrix_info->file,offset,SEEK_SET) < 0)
+    return((MagickOffsetType) -1);
 #endif
+  count=0;
+  for (i=0; i < (MagickOffsetType) length; i+=count)
   {
-    i=(-1);
-    if (lseek(matrix_info->file,offset,SEEK_SET) >= 0)
-      {
-#endif
-        count=0;
-        for (i=0; i < (ssize_t) length; i+=count)
-        {
-#if !defined(MAGICKCORE_HAVE_PPREAD)
-          count=read(matrix_info->file,buffer+i,MagickMin(length-i,(size_t)
-            SSIZE_MAX));
+#if !defined(MAGICKCORE_HAVE_PREAD)
+    count=read(matrix_info->file,buffer+i,(size_t) MagickMin(length-i,
+      (MagickSizeType) SSIZE_MAX));
 #else
-          count=pread(matrix_info->file,buffer+i,MagickMin(length-i,(size_t)
-            SSIZE_MAX),offset+i);
+    count=pread(matrix_info->file,buffer+i,(size_t) MagickMin(length-i,
+      (MagickSizeType) SSIZE_MAX),(off_t) (offset+i));
 #endif
-          if (count > 0)
-            continue;
-          count=0;
-          if (errno != EINTR)
-            {
-              i=(-1);
-              break;
-            }
-        }
-#if !defined(MAGICKCORE_HAVE_PPREAD)
+    if (count <= 0)
+      {
+        count=0;
+        if (errno != EINTR)
+          break;
       }
   }
-#endif
   return(i);
 }
 
@@ -603,11 +681,9 @@ MagickExport MagickBooleanType GetMatrixElement(const MatrixInfo *matrix_info,
   const ssize_t x,const ssize_t y,void *value)
 {
   MagickOffsetType
+    count,
     i;
 
-  ssize_t
-    count;
-
   assert(matrix_info != (const MatrixInfo *) NULL);
   assert(matrix_info->signature == MagickSignature);
   i=(MagickOffsetType) matrix_info->rows*x+y;
@@ -620,9 +696,9 @@ MagickExport MagickBooleanType GetMatrixElement(const MatrixInfo *matrix_info,
         matrix_info->stride);
       return(MagickTrue);
     }
-  count=ReadMatrixInfo(matrix_info,i*matrix_info->stride,matrix_info->stride,
-    value);
-  if (count != matrix_info->stride)
+  count=ReadMatrixElements(matrix_info,i*matrix_info->stride,
+    matrix_info->stride,value);
+  if (count != (MagickOffsetType) matrix_info->stride)
     return(MagickFalse);
   return(MagickTrue);
 }
@@ -750,65 +826,24 @@ MagickExport void LeastSquaresAddTerms(double **matrix,double **vectors,
 %                                                                             %
 %                                                                             %
 %                                                                             %
-%   R e l i n q u i s h M a g i c k M a t r i x                               %
+%   N u l l M a t r i x                                                       %
 %                                                                             %
 %                                                                             %
 %                                                                             %
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %
-%  RelinquishMagickMatrix() frees the previously acquired matrix (array of
-%  pointers to arrays of doubles).
-%
-%  The format of the RelinquishMagickMatrix method is:
-%
-%      double **RelinquishMagickMatrix(double **matrix,
-%        const size_t number_rows)
-%
-%  A description of each parameter follows:
-%
-%    o matrix: the matrix to relinquish
-%
-%    o number_rows: the first dimension of the acquired matrix (number of
-%      pointers)
-%
-*/
-MagickExport double **RelinquishMagickMatrix(double **matrix,
-  const size_t number_rows)
-{
-  register ssize_t
-    i;
-
-  if (matrix == (double **) NULL )
-    return(matrix);
-  for (i=0; i < (ssize_t) number_rows; i++)
-     matrix[i]=(double *) RelinquishMagickMemory(matrix[i]);
-  matrix=(double **) RelinquishMagickMemory(matrix);
-  return(matrix);
-}
-
-/*
-%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
-%                                                                             %
-%                                                                             %
-%                                                                             %
-%   R e s e t M a g i c k M e m o r y                                         %
-%                                                                             %
-%                                                                             %
-%                                                                             %
-%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
-%
-%  ResetMagickMemory() sets all elements of the matrix to zero.
+%  NullMatrix() sets all elements of the matrix to zero.
 %
 %  The format of the ResetMagickMemory method is:
 %
-%      MagickBoolenType *ResetMatrixInfo(MatrixInfo *matrix_info)
+%      MagickBooleanType *NullMatrix(MatrixInfo *matrix_info)
 %
 %  A description of each parameter follows:
 %
 %    o matrix_info: the matrix.
 %
 */
-MagickExport MagickBooleanType ResetMatrixInfo(MatrixInfo *matrix_info)
+MagickExport MagickBooleanType NullMatrix(MatrixInfo *matrix_info)
 {
   register ssize_t
     x;
@@ -849,6 +884,47 @@ MagickExport MagickBooleanType ResetMatrixInfo(MatrixInfo *matrix_info)
 %                                                                             %
 %                                                                             %
 %                                                                             %
+%   R e l i n q u i s h M a g i c k M a t r i x                               %
+%                                                                             %
+%                                                                             %
+%                                                                             %
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+%
+%  RelinquishMagickMatrix() frees the previously acquired matrix (array of
+%  pointers to arrays of doubles).
+%
+%  The format of the RelinquishMagickMatrix method is:
+%
+%      double **RelinquishMagickMatrix(double **matrix,
+%        const size_t number_rows)
+%
+%  A description of each parameter follows:
+%
+%    o matrix: the matrix to relinquish
+%
+%    o number_rows: the first dimension of the acquired matrix (number of
+%      pointers)
+%
+*/
+MagickExport double **RelinquishMagickMatrix(double **matrix,
+  const size_t number_rows)
+{
+  register ssize_t
+    i;
+
+  if (matrix == (double **) NULL )
+    return(matrix);
+  for (i=0; i < (ssize_t) number_rows; i++)
+     matrix[i]=(double *) RelinquishMagickMemory(matrix[i]);
+  matrix=(double **) RelinquishMagickMemory(matrix);
+  return(matrix);
+}
+
+/*
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+%                                                                             %
+%                                                                             %
+%                                                                             %
 %   S e t M a t r i x E l e m e n t                                           %
 %                                                                             %
 %                                                                             %
@@ -874,59 +950,13 @@ MagickExport MagickBooleanType ResetMatrixInfo(MatrixInfo *matrix_info)
 %
 */
 
-static inline ssize_t WriteMatrixInfo(const MatrixInfo *matrix_info,
-  const MagickOffsetType offset,const size_t length,const unsigned char *buffer)
-{
-  register ssize_t
-    i;
-
-  ssize_t
-    count;
-
-  i=0;
-#if !defined(MAGICKCORE_HAVE_PWRITE)
-#if defined(MAGICKCORE_OPENMP_SUPPORT)
-  #pragma omp critical (MagickCore_WriteMatrixInfo)
-#endif
-  {
-    if (lseek(matrix_info->file,offset,SEEK_SET) >= 0)
-      {
-#endif
-        count=0;
-        for (i=0; i < (ssize_t) length; i+=count)
-        {
-#if !defined(MAGICKCORE_HAVE_PWRITE)
-          count=write(matrix_info->file,buffer+i,MagickMin(length-i,(size_t)
-            SSIZE_MAX));
-#else
-          count=pwrite(matrix_info->file,buffer+i,MagickMin(length-i,(size_t)
-            SSIZE_MAX),offset+i);
-#endif
-          if (count > 0)
-            continue;
-          count=0;
-          if (errno != EINTR)
-            {
-              i=(-1);
-              break;
-            }
-        }
-#if !defined(MAGICKCORE_HAVE_PWRITE)
-      }
-  }
-#endif
-  return(i);
-}
-
 MagickExport MagickBooleanType SetMatrixElement(const MatrixInfo *matrix_info,
   const ssize_t x,const ssize_t y,const void *value)
 {
   MagickOffsetType
+    count,
     i;
 
-  ssize_t
-    count;
-
   assert(matrix_info != (const MatrixInfo *) NULL);
   assert(matrix_info->signature == MagickSignature);
   i=(MagickOffsetType) matrix_info->rows*x+y;
@@ -939,9 +969,9 @@ MagickExport MagickBooleanType SetMatrixElement(const MatrixInfo *matrix_info,
         matrix_info->stride);
       return(MagickTrue);
     }
-  count=WriteMatrixInfo(matrix_info,i*matrix_info->stride,matrix_info->stride,
-    value);
-  if (count != (ssize_t) matrix_info->stride)
+  count=WriteMatrixElements(matrix_info,i*matrix_info->stride,
+    matrix_info->stride,value);
+  if (count != (MagickOffsetType) matrix_info->stride)
     return(MagickFalse);
   return(MagickTrue);
 }
diff --git a/MagickCore/matrix.h b/MagickCore/matrix.h
index 6da31b81c..18db3b1ed 100644
--- a/MagickCore/matrix.h
+++ b/MagickCore/matrix.h
@@ -32,7 +32,7 @@ extern MagickExport double
 extern MagickExport MagickBooleanType
   GaussJordanElimination(double **,double **,const size_t,const size_t),
   GetMatrixElement(const MatrixInfo *,const ssize_t,const ssize_t,void *),
-  ResetMatrixInfo(MatrixInfo *),
+  NullMatrix(MatrixInfo *),
   SetMatrixElement(const MatrixInfo *,const ssize_t,const ssize_t,const void *);
 
 MagickExport MatrixInfo
diff --git a/MagickCore/shear.c b/MagickCore/shear.c
index 387b740ff..16dd2ff78 100644
--- a/MagickCore/shear.c
+++ b/MagickCore/shear.c
@@ -370,7 +370,7 @@ static MagickBooleanType RadonTransform(const Image *image,
         source_matrixs=DestroyMatrixInfo(source_matrixs);
       return(MagickFalse);
     }
-  if (ResetMatrixInfo(source_matrixs) == MagickFalse)
+  if (NullMatrix(source_matrixs) == MagickFalse)
     {
       destination_matrixs=DestroyMatrixInfo(destination_matrixs);
       source_matrixs=DestroyMatrixInfo(source_matrixs);
@@ -441,7 +441,7 @@ static MagickBooleanType RadonTransform(const Image *image,
       }
   }
   RadonProjection(image,source_matrixs,destination_matrixs,-1,projection);
-  (void) ResetMatrixInfo(source_matrixs);
+  (void) NullMatrix(source_matrixs);
 #if defined(MAGICKCORE_OPENMP_SUPPORT)
   #pragma omp parallel for schedule(static,4) shared(status) \
     magick_threads(image,image,image->rows,1)