From: Steph Fox Date: Fri, 21 Mar 2008 05:22:10 +0000 (+0000) Subject: Deliberate test breakage (no idea how many) in an attempt to see where the valgrind... X-Git-Tag: RELEASE_2_0_0a1~68 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c11bcd5414dbd179e5abbfce520942fd8e0c705d;p=php Deliberate test breakage (no idea how many) in an attempt to see where the valgrind 'bad news' is coming from on gcov.php.net. --- diff --git a/ext/phar/phar_object.c b/ext/phar/phar_object.c index be5c763fed..e6680a401f 100755 --- a/ext/phar/phar_object.c +++ b/ext/phar/phar_object.c @@ -2442,7 +2442,8 @@ PHP_METHOD(Phar, compressAllFilesGZ) } phar_obj->arc.archive->is_modified = 1; - phar_rename_archive(phar_obj->arc.archive, NULL, 1 TSRMLS_CC); +/* EXPERIMENT: REMOVING THIS LINE TO SEE THE IMPACT ON VALGRIND RESULTS, WILL BREAK TESTS */ + /* phar_rename_archive(phar_obj->arc.archive, NULL, 1 TSRMLS_CC); */ phar_flush(phar_obj->arc.archive, 0, 0, 0, &error TSRMLS_CC); if (error) {