From: Richard Trieu <rtrieu@google.com>
Date: Tue, 20 Sep 2011 20:03:50 +0000 (+0000)
Subject: Fix a problem in digraph handling where "[:" might be treated as "<::" and
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c11030ea936f6952deb5a1423ce1648173cd417e;p=clang

Fix a problem in digraph handling where "[:" might be treated as "<::" and
erronously trigger the digraph correction fix-it.  Include a new test to catch
this in the future.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@140175 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Parse/ParseExprCXX.cpp b/lib/Parse/ParseExprCXX.cpp
index 89953fd3d8..baec6fdd73 100644
--- a/lib/Parse/ParseExprCXX.cpp
+++ b/lib/Parse/ParseExprCXX.cpp
@@ -75,7 +75,7 @@ static void FixDigraph(Parser &P, Preprocessor &PP, Token &DigraphToken,
 void Parser::CheckForTemplateAndDigraph(Token &Next, ParsedType ObjectType,
                                         bool EnteringContext,
                                         IdentifierInfo &II, CXXScopeSpec &SS) {
-  if (!Next.is(tok::l_square) || !Next.getLength() == 2)
+  if (!Next.is(tok::l_square) || Next.getLength() != 2)
     return;
 
   Token SecondToken = GetLookAheadToken(2);
diff --git a/test/Parser/cxx-casting.cpp b/test/Parser/cxx-casting.cpp
index cb82c8efda..42ad12ee94 100644
--- a/test/Parser/cxx-casting.cpp
+++ b/test/Parser/cxx-casting.cpp
@@ -68,7 +68,8 @@ void test2(char x, struct B * b) {
   (void)static_cast LCC c>(&x); // expected-error{{found '<::' after a static_cast which forms the digraph '<:' (aka '[') and a ':', did you mean '< ::'?}}
 }
 
-template <class T> class D {};
+                               // This note comes from "::D[:F> A5;"
+template <class T> class D {}; // expected-note{{template is declared here}}
 template <class T> void E() {};
 class F {};
 
@@ -82,4 +83,10 @@ void test3() {
   D< ::F> A4;
   ::E< ::F>();
   E< ::F>();
+
+  // Make sure that parser doesn't expand '[:' to '< ::'
+  ::D[:F> A5; // expected-error {{cannot refer to class template 'D' without a template argument list}} \
+              // expected-error {{expected expression}} \
+              // expected-error {{expected ']'}} \
+              // expected-note {{to match this '['}}
 }