From: Nikita Popov <nikic@php.net>
Date: Sun, 24 Mar 2013 16:52:16 +0000 (+0100)
Subject: Fix PDO::inTransaction() test for pgsql
X-Git-Tag: php-5.5.0beta2~15^2~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c08e1d2be948d63f7a9309344a0ed4092ac8dace;p=php

Fix PDO::inTransaction() test for pgsql

inTransaction() nowadays casts the in_transaction result to boolean.
I'm not sure whether the INERROR state should result in true or false.
For now I went with the result that we actually get.
---

diff --git a/ext/pdo_pgsql/tests/is_in_transaction.phpt b/ext/pdo_pgsql/tests/is_in_transaction.phpt
index 99ff56162d..72da4f4e07 100644
--- a/ext/pdo_pgsql/tests/is_in_transaction.phpt
+++ b/ext/pdo_pgsql/tests/is_in_transaction.phpt
@@ -57,10 +57,10 @@ var_dump($db->inTransaction());
 ?>
 --EXPECT--
 Test PDO::PGSQL_TRANSACTION_INTRANS
-int(2)
+bool(true)
 Test PDO::PGSQL_TRANSACTION_IDLE
-int(0)
+bool(false)
 Test PDO::PGSQL_TRANSACTION_INERROR
-int(3)
+bool(true)
 Test PDO::PGSQL_TRANSACTION_IDLE
-int(0)
+bool(false)