From: Florian Hahn Date: Thu, 27 Jul 2017 19:56:44 +0000 (+0000) Subject: [ARM] Add use-misched feature, to enable the MachineScheduler. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c080f03f8e0d655bd45019fd22db8973c92f085e;p=llvm [ARM] Add use-misched feature, to enable the MachineScheduler. Summary: This change makes it easier to experiment with the MachineScheduler in the ARM backend and also makes it very explicit which CPUs use the MachineScheduler (currently only swift and cyclone). Reviewers: MatzeB, t.p.northover, javed.absar Reviewed By: MatzeB Subscribers: aemerson, kristof.beyls, llvm-commits Differential Revision: https://reviews.llvm.org/D35935 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@309316 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Target/ARM/ARM.td b/lib/Target/ARM/ARM.td index 762f975dc2a..9c691f548fa 100644 --- a/lib/Target/ARM/ARM.td +++ b/lib/Target/ARM/ARM.td @@ -312,6 +312,9 @@ def FeatureNoNegativeImmediates "equivalent when the immediate does " "not fit in the encoding.">; +// Use the MachineScheduler for instruction scheduling for the subtarget. +def FeatureUseMISched: SubtargetFeature<"use-misched", "UseMISched", "true", + "Use the MachineScheduler">; //===----------------------------------------------------------------------===// // ARM architecture class @@ -791,7 +794,8 @@ def : ProcessorModel<"swift", SwiftModel, [ARMv7a, ProcSwift, FeatureSlowOddRegister, FeatureSlowLoadDSubreg, FeatureSlowVGETLNi32, - FeatureSlowVDUP32]>; + FeatureSlowVDUP32, + FeatureUseMISched]>; def : ProcessorModel<"cortex-r4", CortexA8Model, [ARMv7r, ProcR4, FeatureHasRetAddrStack, @@ -915,6 +919,7 @@ def : ProcessorModel<"cyclone", SwiftModel, [ARMv8a, ProcSwift, FeatureAvoidMOVsShOp, FeatureHasSlowFPVMLx, FeatureCrypto, + FeatureUseMISched, FeatureZCZeroing]>; def : ProcNoItin<"exynos-m1", [ARMv8a, ProcExynosM1, diff --git a/lib/Target/ARM/ARMSubtarget.cpp b/lib/Target/ARM/ARMSubtarget.cpp index 8063c1ee3c5..78bcbb77029 100644 --- a/lib/Target/ARM/ARMSubtarget.cpp +++ b/lib/Target/ARM/ARMSubtarget.cpp @@ -396,17 +396,16 @@ bool ARMSubtarget::hasSinCos() const { } bool ARMSubtarget::enableMachineScheduler() const { - // Enable the MachineScheduler before register allocation for out-of-order - // architectures where we do not use the PostRA scheduler anymore (for now - // restricted to swift). - return getSchedModel().isOutOfOrder() && isSwift(); + // Enable the MachineScheduler before register allocation for subtargets + // with the use-misched feature. + return useMachineScheduler(); } // This overrides the PostRAScheduler bit in the SchedModel for any CPU. bool ARMSubtarget::enablePostRAScheduler() const { - // No need for PostRA scheduling on out of order CPUs (for now restricted to - // swift). - if (getSchedModel().isOutOfOrder() && isSwift()) + // No need for PostRA scheduling on subtargets where we use the + // MachineScheduler. + if (useMachineScheduler()) return false; return (!isThumb() || hasThumb2()); } diff --git a/lib/Target/ARM/ARMSubtarget.h b/lib/Target/ARM/ARMSubtarget.h index e15b17512c9..400d185e9fd 100644 --- a/lib/Target/ARM/ARMSubtarget.h +++ b/lib/Target/ARM/ARMSubtarget.h @@ -180,6 +180,9 @@ protected: /// UseSoftFloat - True if we're using software floating point features. bool UseSoftFloat = false; + /// UseMISched - True if MachineScheduler should be used for this subtarget. + bool UseMISched = false; + /// HasThumb2 - True if Thumb2 instructions are supported. bool HasThumb2 = false; @@ -645,6 +648,7 @@ public: bool isROPI() const; bool isRWPI() const; + bool useMachineScheduler() const { return UseMISched; } bool useSoftFloat() const { return UseSoftFloat; } bool isThumb() const { return InThumbMode; } bool isThumb1Only() const { return InThumbMode && !HasThumb2; }