From: Kevin McCarthy <kevin@8t8.us>
Date: Sun, 26 May 2019 23:03:40 +0000 (-0700)
Subject: Change mutt_addr_is_user() to no for a NULL address
X-Git-Tag: 2019-10-25~168^2~4
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c050a085f0150aa472fafdd739994948b7df2bf2;p=neomutt

Change mutt_addr_is_user() to no for a NULL address

The behavior is generating a false 'F' flag for a spam message with an
unparsable From address.

After reviewing the callers, I can't see a reason returning 'yes' in
this case.

Co-authored-by: Richard Russon <rich@flatcap.org>
---

diff --git a/alias.c b/alias.c
index 5ae0ce069..a39295a8b 100644
--- a/alias.c
+++ b/alias.c
@@ -669,11 +669,10 @@ int mutt_alias_complete(char *buf, size_t buflen)
  */
 bool mutt_addr_is_user(const struct Address *addr)
 {
-  /* NULL address is assumed to be the user. */
   if (!addr)
   {
-    mutt_debug(5, "yes, NULL address\n");
-    return true;
+    mutt_debug(5, "no, NULL address\n");
+    return false;
   }
   if (!addr->mailbox)
   {