From: Douglas Gregor <dgregor@apple.com>
Date: Thu, 2 Dec 2010 19:33:37 +0000 (+0000)
Subject: Fix inverted return value in the ASTImporter. No matter how much LLVM
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c04d9d1be026cb201a716df1cd28a88878958bee;p=clang

Fix inverted return value in the ASTImporter. No matter how much LLVM
code I wrote, returning "true" on error is still unnatural.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@120727 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/AST/ASTImporter.cpp b/lib/AST/ASTImporter.cpp
index 0628fea476..e9bb3ad960 100644
--- a/lib/AST/ASTImporter.cpp
+++ b/lib/AST/ASTImporter.cpp
@@ -1694,7 +1694,7 @@ bool ASTNodeImporter::ImportDefinition(RecordDecl *From, RecordDecl *To) {
          ++Base1) {
       QualType T = Importer.Import(Base1->getType());
       if (T.isNull())
-        return false;
+        return true;
       
       Bases.push_back(
                     new (Importer.getToContext()) 
@@ -1710,7 +1710,7 @@ bool ASTNodeImporter::ImportDefinition(RecordDecl *From, RecordDecl *To) {
   
   ImportDeclContext(From);
   To->completeDefinition();
-  return true;
+  return false;
 }
 
 TemplateParameterList *ASTNodeImporter::ImportTemplateParameterList(