From: Ilia Alshanetsky Date: Thu, 13 Nov 2008 18:21:54 +0000 (+0000) Subject: MFB: Fixed a bug inside dba_replace() that could cause file truncation with X-Git-Tag: BEFORE_HEAD_NS_CHANGES_MERGE~182 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c037b6175f7c397fec97fa23830b69c6bea45bec;p=php MFB: Fixed a bug inside dba_replace() that could cause file truncation with invalid keys --- diff --git a/ext/dba/libinifile/inifile.c b/ext/dba/libinifile/inifile.c index 22f8063f6f..9a81dd09a1 100644 --- a/ext/dba/libinifile/inifile.c +++ b/ext/dba/libinifile/inifile.c @@ -507,7 +507,9 @@ static int inifile_delete_replace_append(inifile *dba, const key_type *key, cons /* 5 */ if (ret == SUCCESS) { - ret = inifile_truncate(dba, append ? pos_grp_next : pos_grp_start TSRMLS_CC); /* writes error on fail */ + if (!value || (key->name && strlen(key->name))) { + ret = inifile_truncate(dba, append ? pos_grp_next : pos_grp_start TSRMLS_CC); /* writes error on fail */ + } } if (ret == SUCCESS) {