From: Andrei Zmievski <andrei@php.net>
Date: Sat, 4 Aug 2001 16:54:20 +0000 (+0000)
Subject: @- Fixed a crash bug in array_map() when NULL callback was passed in. (Andrei)
X-Git-Tag: PRE_ENGINE2_SPLIT~70
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bffbe675f939ff6da54e10f2361c4fbae1344e52;p=php

@- Fixed a crash bug in array_map() when NULL callback was passed in. (Andrei)
---

diff --git a/ext/standard/array.c b/ext/standard/array.c
index 3a85caeb63..f18621ad1d 100644
--- a/ext/standard/array.c
+++ b/ext/standard/array.c
@@ -3010,14 +3010,15 @@ PHP_FUNCTION(array_map)
 	}
 
 	callback = *args[0];
-	if (Z_TYPE_P(callback) != IS_NULL && !zend_is_callable(callback, 0, &callback_name)) {
-		php_error(E_WARNING, "%s() expects argument 1, '%s', to be either NULL or a valid callback",
-				  get_active_function_name(TSRMLS_C), callback_name);
+	if (Z_TYPE_P(callback) != IS_NULL) {
+		if (!zend_is_callable(callback, 0, &callback_name)) {
+			php_error(E_WARNING, "%s() expects argument 1, '%s', to be either NULL or a valid callback", get_active_function_name(TSRMLS_C), callback_name);
+			efree(callback_name);
+			efree(args);
+			return;
+		}
 		efree(callback_name);
-		efree(args);
-		return;
 	}
-	efree(callback_name);
 
 	/* Cache array sizes. */
 	array_len = (int*)emalloc((ZEND_NUM_ARGS()-1) * sizeof(int));