From: Guido van Rossum Date: Thu, 22 Mar 2001 21:59:20 +0000 (+0000) Subject: This is SF patch #405952, by Anthony Baxter: X-Git-Tag: v2.1b2~62 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bfb9184ba80fc14a6d773e72fc591250f668ed3a;p=python This is SF patch #405952, by Anthony Baxter: cmd.py uses raw_input(); eats SIGCLD: I discovered a rather nasty side effect of the standard cmd.py library today. If it's sitting inside raw_input(), any SIGCLDs that get sent to your application get silently eaten and ignored. I'm assuming that this is something that readline is thoughtfully doing for me. This patch adds an instance attr that allows the user to select to not use raw_input(), but instead use sys.stdin.readline() [Changed slightly to catch EOFError only for raw_input().] --- diff --git a/Lib/cmd.py b/Lib/cmd.py index dcf601f4f2..10c11a2221 100644 --- a/Lib/cmd.py +++ b/Lib/cmd.py @@ -35,7 +35,7 @@ These interpreters use raw_input; thus, if the readline module is loaded, they automatically support Emacs-like command history and editing features. """ -import string +import string, sys __all__ = ["Cmd"] @@ -54,6 +54,7 @@ class Cmd: misc_header = "Miscellaneous help topics:" undoc_header = "Undocumented commands:" nohelp = "*** No help on %s" + use_rawinput = 1 def __init__(self): pass @@ -69,10 +70,18 @@ class Cmd: line = self.cmdqueue[0] del self.cmdqueue[0] else: - try: - line = raw_input(self.prompt) - except EOFError: - line = 'EOF' + if self.use_rawinput: + try: + line = raw_input(self.prompt) + except EOFError: + line = 'EOF' + else: + sys.stdout.write(self.prompt) + line = sys.stdin.readline() + if not len(line): + line = 'EOF' + else: + line = line[:-1] # chop \n line = self.precmd(line) stop = self.onecmd(line) stop = self.postcmd(stop, line)