From: Senthil Kumaran Date: Tue, 23 Oct 2012 18:07:02 +0000 (-0700) Subject: Fix the windows buildbot permission error - close the fd of tempfile beffore unlinking X-Git-Tag: v3.4.0a1~2177 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bf644c5571a8e2acb380c7a1288af217f0be7cd6;p=python Fix the windows buildbot permission error - close the fd of tempfile beffore unlinking --- diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py index 2eac4e3cec..d8c3512fa8 100644 --- a/Lib/test/test_urllib.py +++ b/Lib/test/test_urllib.py @@ -278,12 +278,13 @@ Content-Type: text/html; charset=iso-8859-1 def test_file_notexists(self): fd, tmp_file = tempfile.mkstemp() tmp_fileurl = 'file://localhost/' + tmp_file.replace(os.path.sep, '/') - - self.assertTrue(os.path.exists(tmp_file)) - with urlopen(tmp_fileurl) as fobj: - self.assertTrue(fobj) - - os.unlink(tmp_file) + try: + self.assertTrue(os.path.exists(tmp_file)) + with urlopen(tmp_fileurl) as fobj: + self.assertTrue(fobj) + finally: + os.close(fd) + os.unlink(tmp_file) self.assertFalse(os.path.exists(tmp_file)) with self.assertRaises(urllib.error.URLError): urlopen(tmp_fileurl)