From: Daniel Stenberg <daniel@haxx.se>
Date: Sat, 21 Dec 2013 23:17:58 +0000 (+0100)
Subject: Curl_pp_readresp: zero terminate line
X-Git-Tag: curl-7_35_0~206
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bf468fb58950480289450b94943f1dec0185f739;p=curl

Curl_pp_readresp: zero terminate line

The comment in the code mentions the zero terminating after having
copied data, but it mistakingly zero terminated the source data and not
the destination! This caused the test 864 problem discussed on the list:

http://curl.haxx.se/mail/lib-2013-12/0113.html
Signed-off-by: Daniel Stenberg <daniel@haxx.se>
---

diff --git a/lib/pingpong.c b/lib/pingpong.c
index 683ae1963..1b2ccd9b5 100644
--- a/lib/pingpong.c
+++ b/lib/pingpong.c
@@ -380,7 +380,7 @@ CURLcode Curl_pp_readresp(curl_socket_t sockfd,
             int n;
             for(meow=pp->linestart_resp, n=0; meow<ptr; meow++, n++)
               buf[n] = *meow;
-            *meow=0; /* zero terminate */
+            buf[n]=0; /* zero terminate */
             keepon=FALSE;
             pp->linestart_resp = ptr+1; /* advance pointer */
             i++; /* skip this before getting out */