From: Younies Mahmoud Date: Fri, 20 Mar 2020 14:44:31 +0000 (+0100) Subject: fix building units router branch X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bf1a9bb7a09d0eb2ca3d8efea3483089e0dc373b;p=icu fix building units router branch --- diff --git a/icu4c/source/i18n/unitsrouter.h b/icu4c/source/i18n/unitsrouter.h index a8438e2cdfe..3dd1f4d749c 100644 --- a/icu4c/source/i18n/unitsrouter.h +++ b/icu4c/source/i18n/unitsrouter.h @@ -53,10 +53,10 @@ class U_I18N_API UnitsRouter { MaybeStackVector converterPreferences_; }; -void getUnitsData(const char *outputRegion, const char *usage, const MeasureUnit &inputUnit, - CharString &category, MeasureUnit &baseUnit, - MaybeStackVector &conversionInfo, - MaybeStackVector &unitPreferences, UErrorCode &status); +void U_I18N_API getUnitsData(const char *outputRegion, const char *usage, const MeasureUnit &inputUnit, + CharString &category, MeasureUnit &baseUnit, + MaybeStackVector &conversionInfo, + MaybeStackVector &unitPreferences, UErrorCode &status); U_NAMESPACE_END diff --git a/icu4c/source/test/intltest/unitsroutertest.cpp b/icu4c/source/test/intltest/unitsroutertest.cpp index 8e897dc0d12..8d2489e577e 100644 --- a/icu4c/source/test/intltest/unitsroutertest.cpp +++ b/icu4c/source/test/intltest/unitsroutertest.cpp @@ -7,6 +7,8 @@ #include "intltest.h" #include "unicode/unistr.h" +#include "unitsrouter.h" + class UnitsRouterTest : public IntlTest { public: diff --git a/icu4c/source/test/intltest/unitstest.cpp b/icu4c/source/test/intltest/unitstest.cpp index 5862097379a..08cde6a73cd 100644 --- a/icu4c/source/test/intltest/unitstest.cpp +++ b/icu4c/source/test/intltest/unitstest.cpp @@ -5,6 +5,8 @@ #if !UCONFIG_NO_FORMATTING +#include + #include "charstr.h" #include "filestrm.h" #include "intltest.h" @@ -16,7 +18,6 @@ #include "unitconverter.h" #include "unitsrouter.h" #include "uparse.h" -#include struct UnitConversionTestCase { const StringPiece source; @@ -54,9 +55,7 @@ class UnitsTest : public IntlTest { extern IntlTest *createUnitsTest() { return new UnitsTest(); } void UnitsTest::runIndexedTest(int32_t index, UBool exec, const char *&name, char * /*par*/) { - if (exec) { - logln("TestSuite UnitsTest: "); - } + if (exec) { logln("TestSuite UnitsTest: "); } TESTCASE_AUTO_BEGIN; TESTCASE_AUTO(testConversions); TESTCASE_AUTO(testPreferences); @@ -811,28 +810,29 @@ void UnitsTest::testGetUnitsData() { MaybeStackVector unitPreferences; getUnitsData(t.outputRegion, t.usage, inputUnit, category, baseUnit, conversionInfo, unitPreferences, status); - if (status.errIfFailureAndReset("getUnitsData(\"%s\", \"%s\", \"%s\", ...)", t.outputRegion, t.usage, t.inputUnit)) { + if (status.errIfFailureAndReset("getUnitsData(\"%s\", \"%s\", \"%s\", ...)", t.outputRegion, + t.usage, t.inputUnit)) { continue; } logln("category: \"%s\", baseUnit: \"%s\"", category.data(), baseUnit.getIdentifier()); - for (int i=0; i < conversionInfo.length(); i++) { + for (int i = 0; i < conversionInfo.length(); i++) { ConversionRateInfo *cri; cri = conversionInfo[i]; logln("conversionInfo %d: source=\"%s\", target=\"%s\", factor=\"%s\", offset=\"%s\"", i, cri->source.data(), cri->target.data(), cri->factor.data(), cri->offset.data()); } - for (int i=0; i < unitPreferences.length(); i++) { + for (int i = 0; i < unitPreferences.length(); i++) { UnitPreference *up; up = unitPreferences[i]; - logln("unitPreference %d: \"%s\", geq=%f, skeleton=\"%s\"", i, up->unit.data(), - up->geq, up->skeleton.data()); + logln("unitPreference %d: \"%s\", geq=%f, skeleton=\"%s\"", i, up->unit.data(), up->geq, + up->skeleton.data()); } } +} + /** * Tests different return statuses depending on the input. */ -void UnitsTest::testStatus() { - -} +void UnitsTest::testStatus() {} #endif /* #if !UCONFIG_NO_FORMATTING */