From: Douglas Gregor <dgregor@apple.com>
Date: Thu, 22 Dec 2011 22:05:07 +0000 (+0000)
Subject: Make a note for an optimization that I'd like to implement, when the ASTs for local... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bf1739c10ab875156b5fa61f9b92964ef8b68ed5;p=clang

Make a note for an optimization that I'd like to implement, when the ASTs for local externs are sound

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@147185 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Serialization/ASTReaderDecl.cpp b/lib/Serialization/ASTReaderDecl.cpp
index cb816632bd..3819191e0c 100644
--- a/lib/Serialization/ASTReaderDecl.cpp
+++ b/lib/Serialization/ASTReaderDecl.cpp
@@ -131,6 +131,14 @@ namespace clang {
       }
 
       ~RedeclarableResult() {
+        // FIXME: We want to suppress this when the declaration is local to
+        // a function, since there's no reason to search other AST files
+        // for redeclarations (they can't exist). However, this is hard to 
+        // do locally because the declaration hasn't necessarily loaded its
+        // declaration context yet. Also, local externs still have the function
+        // as their (semantic) declaration context, which is wrong and would
+        // break this optimize.
+        
         if (FirstID && Owning && Reader.PendingDeclChainsKnown.insert(FirstID))
           Reader.PendingDeclChains.push_back(FirstID);
       }