From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 17 Jul 2013 22:27:19 +0000 (-0700)
Subject: diff: reject unknown change class given to --diff-filter
X-Git-Tag: v1.8.5-rc0~173^2~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bf142ec4346385553918bc53f203b205091aa362;p=git

diff: reject unknown change class given to --diff-filter

We used to accept "git diff --diff-filter=Q" (note that there is no
such change class 'Q') silently and showed no output (because there
is no such change class 'Q').

Error out when such an input is given.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/diff.c b/diff.c
index 03f10e6516..3d37b56778 100644
--- a/diff.c
+++ b/diff.c
@@ -3537,7 +3537,7 @@ static int parse_diff_filter_opt(const char *optarg, struct diff_options *opt)
 
 		bit = (0 <= optch && optch <= 'Z') ? filter_bit[optch] : 0;
 		if (!bit)
-			continue; /* ignore unknown ones, like we always have */
+			return optarg[i];
 		opt->filter |= bit;
 	}
 	return 0;