From: Chris Dunlap <cdunlap@llnl.gov>
Date: Thu, 11 Sep 2014 22:41:35 +0000 (-0700)
Subject: Fix zed io-spare.sh dash incompatibility
X-Git-Tag: zfs-0.6.4~154
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bee6665;p=zfs

Fix zed io-spare.sh dash incompatibility

The zed's io-spare.sh script defines a vdev_status() function to query
the 'zpool status' output for obtaining the status of a specified vdev.
This function contains a small awk script that uses a parameter
expansion (${parameter/pattern/string}) supported in bash but not
in dash.  Under dash, this fails with a "Bad substitution" error.

This commit replaces the awk script with a (hopefully more portable)
sed script that has been tested under both bash and dash.

Signed-off-by: Chris Dunlap <cdunlap@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #2536
---

diff --git a/cmd/zed/zed.d/io-spare.sh b/cmd/zed/zed.d/io-spare.sh
index dd5bf4e0f..894817317 100755
--- a/cmd/zed/zed.d/io-spare.sh
+++ b/cmd/zed/zed.d/io-spare.sh
@@ -54,10 +54,11 @@ flock -x 8
 # Given a <pool> and <device> return the status, (ONLINE, FAULTED, etc...).
 vdev_status() {
 	local POOL=$1
-	local VDEV=`basename $2`
+	local VDEV=$2
+	local T='	'	# tab character since '\t' isn't portable
 
-	${ZPOOL} status ${POOL} | \
-	    awk -v pat="${VDEV}|${VDEV/-part?}" '$0 ~ pat { print $1" "$2 }'
+	${ZPOOL} status ${POOL} | sed -n -e \
+	    "s,^[ $T]*\(.*$VDEV\(-part[0-9]\+\)\?\)[ $T]*\([A-Z]\+\).*,\1 \3,p"
 	return 0
 }