From: Victor Stinner <victor.stinner@gmail.com>
Date: Mon, 27 Jul 2015 21:37:11 +0000 (+0200)
Subject: Issue #24732, #23834: Fix sock_accept_impl() on Windows
X-Git-Tag: v3.6.0a1~1899^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bea232a15fc818341217901772c7e622e9f9332d;p=python

Issue #24732, #23834: Fix sock_accept_impl() on Windows

accept() returns INVALID_SOCKET on error, it's not necessary a negative number.
---

diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index 7610b0c05d..ee249070c3 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -2211,7 +2211,12 @@ sock_accept_impl(PySocketSockObject *s, void *data)
 #else
     ctx->result = accept(s->sock_fd, SAS2SA(ctx->addrbuf), ctx->addrlen);
 #endif
+
+#ifdef MS_WINDOWS
+    return (ctx->result != INVALID_SOCKET);
+#else
     return (ctx->result >= 0);
+#endif
 }
 
 /* s._accept() -> (fd, address) */