From: Turbo Fredriksson <turbo@bayour.com>
Date: Tue, 2 Apr 2013 16:27:52 +0000 (-0700)
Subject: Add smb_available() sanity checks
X-Git-Tag: zfs-0.6.2~119
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=be8bc8c0d3ff16888f046e8523051b514ad285e0;p=zfs

Add smb_available() sanity checks

Do basic sanity checks in smb_available() to verify that the 'net'
command and the usershare directory exists.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #1124
---

diff --git a/lib/libshare/smb.c b/lib/libshare/smb.c
index e34d14259..a545bfb0f 100644
--- a/lib/libshare/smb.c
+++ b/lib/libshare/smb.c
@@ -423,7 +423,15 @@ static const sa_share_ops_t smb_shareops = {
 static boolean_t
 smb_available(void)
 {
-	/* TODO: Sanity check NET_CMD_PATH and SHARE_DIR */
+	struct stat statbuf;
+
+	if (lstat(SHARE_DIR, &statbuf) != 0 ||
+	    !S_ISDIR(statbuf.st_mode))
+		return B_FALSE;
+
+	if (access(NET_CMD_PATH, F_OK) != 0)
+		return B_FALSE;
+
 	return B_TRUE;
 }