From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 23 Jun 2017 14:13:12 +0000 (+0200)
Subject: rec: Accept NXD denial state instead of NXQ for an empty non-terminal
X-Git-Tag: rec-4.1.0-alpha1~50^2~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=be87d89e6afeebaa10aaa143f2d578565ae00f26;p=pdns

rec: Accept NXD denial state instead of NXQ for an empty non-terminal
---

diff --git a/pdns/syncres.cc b/pdns/syncres.cc
index 4ec365d4e..5899578fc 100644
--- a/pdns/syncres.cc
+++ b/pdns/syncres.cc
@@ -1834,6 +1834,10 @@ void SyncRes::getDenialValidationState(NegCache::NegCacheEntry& ne, vState& stat
         LOG(d_prefix<<"Insecure denial found for "<<ne.d_name<<", retuning Insecure"<<endl);
         ne.d_validationState = Insecure;
       }
+      if (res == NXDOMAIN && expectedState == NXQTYPE) {
+        /* might happen for empty non-terminal, have fun */
+        return;
+      }
       else {
         LOG(d_prefix<<"Invalid denial found for "<<ne.d_name<<", retuning Bogus"<<endl);
         ne.d_validationState = Bogus;