From: Bram Moolenaar Date: Sun, 20 Mar 2016 20:02:00 +0000 (+0100) Subject: patch 7.4.1625 X-Git-Tag: v7.4.1625 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=be6aa46c4d8948e164f7d181dc19ed2fc4818395;p=vim patch 7.4.1625 Problem: Trying to close file descriptor that isn't open. Solution: Check for negative number. --- diff --git a/src/os_unix.c b/src/os_unix.c index 4cc9de7c4..cda5407f8 100644 --- a/src/os_unix.c +++ b/src/os_unix.c @@ -5214,11 +5214,11 @@ mch_start_job(char **argv, job_T *job, jobopt_T *options UNUSED) job->jv_channel = channel; /* ch_refcount was set above */ /* child stdin, stdout and stderr */ - if (!use_file_for_in) + if (!use_file_for_in && fd_in[0] >= 0) close(fd_in[0]); - if (!use_file_for_out) + if (!use_file_for_out && fd_out[1] >= 0) close(fd_out[1]); - if (!use_out_for_err && !use_file_for_err) + if (!use_out_for_err && !use_file_for_err && fd_err[1] >= 0) close(fd_err[1]); if (channel != NULL) { diff --git a/src/version.c b/src/version.c index d465d8151..7e1b515ab 100644 --- a/src/version.c +++ b/src/version.c @@ -748,6 +748,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 1625, /**/ 1624, /**/