From: Sami Kerola <kerolasa@iki.fi>
Date: Sat, 24 Nov 2012 10:48:18 +0000 (+0000)
Subject: clean up: reduce variable passing when they are not used
X-Git-Tag: cronie1.4.10~17
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=be643ac0c074eda240c714cd1cb7f8ea9b3fd4f9;p=cronie

clean up: reduce variable passing when they are not used

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/src/database.c b/src/database.c
index 0bb305c..09d56fd 100644
--- a/src/database.c
+++ b/src/database.c
@@ -49,7 +49,7 @@ static void max_mtime(char *dir_name, struct stat *max_st);
 /* record max mtime of any file under dir_name in max_st */
 
 static int
-check_open(const char *tabname, const char *fname, const char *uname,
+check_open(const char *tabname, const char *uname,
 	struct passwd *pw, time_t * mtime) {
 	struct stat statbuf;
 	int crontab_fd;
@@ -185,7 +185,7 @@ process_crontab(const char *uname, const char *fname, const char *tabname,
 		goto next_crontab;
 	}
 
-	if ((crontab_fd = check_open(tabname, fname, uname, pw, &mtime)) == -1)
+	if ((crontab_fd = check_open(tabname, uname, pw, &mtime)) == -1)
 		goto next_crontab;
 
 	Debug(DLOAD, ("\t%s:", fname))
diff --git a/src/do_command.c b/src/do_command.c
index bde731c..be261a9 100644
--- a/src/do_command.c
+++ b/src/do_command.c
@@ -21,7 +21,7 @@
 
 #include <cron.h>
 
-static int child_process(entry *, user *, char **);
+static int child_process(entry *, char **);
 static int safe_p(const char *, const char *);
 
 void do_command(entry * e, user * u) {
@@ -52,7 +52,7 @@ void do_command(entry * e, user * u) {
 		if (cron_set_job_security_context(e, u, &jobenv) != 0) {
 			_exit(ERROR_EXIT);
 		}
-		ev = child_process(e, u, jobenv);
+		ev = child_process(e, jobenv);
 		cron_close_pam();
 		env_free(jobenv);
 		Debug(DPROC, ("[%ld] child process done, exiting\n", (long) getpid()))
@@ -65,7 +65,7 @@ void do_command(entry * e, user * u) {
 	Debug(DPROC, ("[%ld] main process returning to work\n", (long) pid))
 }
 
-static int child_process(entry * e, user * u, char **jobenv) {
+static int child_process(entry * e, char **jobenv) {
 	int stdin_pipe[2], stdout_pipe[2];
 	char *input_data, *usernm, *mailto, *mailfrom;
 	int children = 0;