From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 4 May 2017 13:57:55 +0000 (+0200)
Subject: receive-pack: plug memory leak in update()
X-Git-Tag: v2.13.1~27^2~8
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bda6e82801e3c01d51634e6c722783295fd079ae;p=git

receive-pack: plug memory leak in update()

Reported via Coverity.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index f96834f42c..48c07ddb65 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -986,7 +986,8 @@ static const char *update(struct command *cmd, struct shallow_info *si)
 {
 	const char *name = cmd->ref_name;
 	struct strbuf namespaced_name_buf = STRBUF_INIT;
-	const char *namespaced_name, *ret;
+	static char *namespaced_name;
+	const char *ret;
 	struct object_id *old_oid = &cmd->old_oid;
 	struct object_id *new_oid = &cmd->new_oid;
 
@@ -997,6 +998,7 @@ static const char *update(struct command *cmd, struct shallow_info *si)
 	}
 
 	strbuf_addf(&namespaced_name_buf, "%s%s", get_git_namespace(), name);
+	free(namespaced_name);
 	namespaced_name = strbuf_detach(&namespaced_name_buf, NULL);
 
 	if (is_ref_checked_out(namespaced_name)) {