From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Wed, 4 Apr 2018 16:51:34 +0000 (-0700)
Subject: Call super in Generic.__init_subclass__ (GH-6356)
X-Git-Tag: v3.7.0b4~77
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bd85c9738296cf4a53859ed17e9a6812d2071a21;p=python

Call super in Generic.__init_subclass__ (GH-6356)

(cherry picked from commit ee566fe526f3d069aa313578ee81ca6cbc25ff52)

Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
---

diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index 09e39fec45..b12e5ea2fb 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -1232,6 +1232,25 @@ class GenericTests(BaseTestCase):
         class C(List[int], B): ...
         self.assertEqual(C.__mro__, (C, list, B, Generic, object))
 
+    def test_init_subclass_super_called(self):
+        class FinalException(Exception):
+            pass
+
+        class Final:
+            def __init_subclass__(cls, **kwargs) -> None:
+                for base in cls.__bases__:
+                    if base is not Final and issubclass(base, Final):
+                        raise FinalException(base)
+                super().__init_subclass__(**kwargs)
+        class Test(Generic[T], Final):
+            pass
+        with self.assertRaises(FinalException):
+            class Subclass(Test):
+                pass
+        with self.assertRaises(FinalException):
+            class Subclass(Test[int]):
+                pass
+
     def test_nested(self):
 
         G = Generic
diff --git a/Lib/typing.py b/Lib/typing.py
index 510574c413..3ac3b93822 100644
--- a/Lib/typing.py
+++ b/Lib/typing.py
@@ -850,6 +850,7 @@ class Generic:
         return _GenericAlias(cls, params)
 
     def __init_subclass__(cls, *args, **kwargs):
+        super().__init_subclass__(*args, **kwargs)
         tvars = []
         if '__orig_bases__' in cls.__dict__:
             error = Generic in cls.__orig_bases__