From: Ian Holsman <ianh@apache.org>
Date: Fri, 30 Aug 2002 16:08:03 +0000 (+0000)
Subject: deflate's filter removal was reversed for non-html files, resulting
X-Git-Tag: AGB_BEFORE_AAA_CHANGES~111
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bd056e1dc7dfb1ae3e9c42f2955973d4f75bc111;p=apache

deflate's filter removal was reversed for non-html files, resulting
in it never being applied for non-html files
Submitted by:	Kris Verbeeck <Kris.Verbeeck@ubizen.com>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@96588 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/CHANGES b/CHANGES
index af32a05ec3..bbba4e82b4 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,5 +1,8 @@
 Changes with Apache 2.0.41
 
+  *) Fix Logic on non-html file removal in mod_deflate
+     [Kris Verbeeck <Kris.Verbeeck@ubizen.com>]
+
   *) Fix "ab -g"'s truncated year: the last digit was cut off.
      [Leon Brocard <acme@astray.com>]
 
diff --git a/modules/filters/mod_deflate.c b/modules/filters/mod_deflate.c
index a456b0258e..d7a7e2a9d4 100644
--- a/modules/filters/mod_deflate.c
+++ b/modules/filters/mod_deflate.c
@@ -281,7 +281,7 @@ static apr_status_t deflate_out_filter(ap_filter_t *f,
              || strncmp(r->content_type, "text/html", 9)) {
             const char *env_value = apr_table_get(r->subprocess_env,
                                                   "gzip-only-text/html");
-            if ( env_value == NULL || strcmp(env_value,"1") ) {
+            if ( env_value && (strcmp(env_value,"1") == 0) ) {
                 ap_remove_output_filter(f);
             }
             return ap_pass_brigade(f->next, bb);