From: Victor Stinner <victor.stinner@gmail.com>
Date: Tue, 22 Nov 2016 14:30:38 +0000 (+0100)
Subject: Issue #28727: Optimize pattern_richcompare() for a==a
X-Git-Tag: v3.6.0rc1~38
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bcf4dccfa77df6fd75181e2a7cbfbf2d4b2c6255;p=python

Issue #28727: Optimize pattern_richcompare() for a==a

A pattern is equal to itself.
---

diff --git a/Lib/test/test_re.py b/Lib/test/test_re.py
index 4fcd2d463d..84131d2b92 100644
--- a/Lib/test/test_re.py
+++ b/Lib/test/test_re.py
@@ -1781,6 +1781,10 @@ SUBPATTERN None 0 0
     def test_pattern_compare(self):
         pattern1 = re.compile('abc', re.IGNORECASE)
 
+        # equal to itself
+        self.assertEqual(pattern1, pattern1)
+        self.assertFalse(pattern1 != pattern1)
+
         # equal
         re.purge()
         pattern2 = re.compile('abc', re.IGNORECASE)
diff --git a/Modules/_sre.c b/Modules/_sre.c
index 1b7741696d..979e61fb53 100644
--- a/Modules/_sre.c
+++ b/Modules/_sre.c
@@ -2683,6 +2683,12 @@ pattern_richcompare(PyObject *lefto, PyObject *righto, int op)
     if (Py_TYPE(lefto) != &Pattern_Type || Py_TYPE(righto) != &Pattern_Type) {
         Py_RETURN_NOTIMPLEMENTED;
     }
+
+    if (lefto == righto) {
+        /* a pattern is equal to itself */
+        return PyBool_FromLong(op == Py_EQ);
+    }
+
     left = (PatternObject *)lefto;
     right = (PatternObject *)righto;