From: Michael Friedrich <Michael.Friedrich@netways.de>
Date: Wed, 19 Mar 2014 21:08:28 +0000 (+0100)
Subject: Fix missing lock and clear ack comments in RemoveHostAcknowledgement().
X-Git-Tag: v0.0.9~67
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bcc17be2cab69b7a0e70ca00c4a3e65ab404ece7;p=icinga2

Fix missing lock and clear ack comments in RemoveHostAcknowledgement().
---

diff --git a/lib/icinga/externalcommandprocessor.cpp b/lib/icinga/externalcommandprocessor.cpp
index 50a8ba452..e752707c4 100644
--- a/lib/icinga/externalcommandprocessor.cpp
+++ b/lib/icinga/externalcommandprocessor.cpp
@@ -733,8 +733,13 @@ void ExternalCommandProcessor::RemoveHostAcknowledgement(double, const std::vect
 
 	Log(LogInformation, "icinga", "Removing acknowledgement for host '" + host->GetName() + "'");
 	Service::Ptr service = host->GetCheckService();
-	if (service)
-		service->ClearAcknowledgement();
+	if (service) {
+		{
+			ObjectLock olock(service);
+			service->ClearAcknowledgement();
+		}
+		service->RemoveCommentsByType(CommentAcknowledgement);
+	}
 }
 
 void ExternalCommandProcessor::EnableHostgroupSvcChecks(double, const std::vector<String>& arguments)