From: Ben Laurie <ben@apache.org>
Date: Sun, 10 Mar 2002 20:49:29 +0000 (+0000)
Subject: Be a better example.
X-Git-Tag: CHANGES~148
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bc9f45eadcfb5a96ba91e769cd8ece3acd24724f;p=apache

Be a better example.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93832 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/experimental/mod_case_filter.c b/modules/experimental/mod_case_filter.c
index ae0209d832..c19fa928a9 100644
--- a/modules/experimental/mod_case_filter.c
+++ b/modules/experimental/mod_case_filter.c
@@ -58,21 +58,18 @@ static apr_status_t CaseFilterOutFilter(ap_filter_t *f,
             /* XXX: why can't I reuse pbktIn??? */
 	    apr_bucket *pbktEOS=apr_bucket_eos_create();
 	    APR_BRIGADE_INSERT_TAIL(pbbOut,pbktEOS);
-	    break;
+	    continue;
 	    }
 
 	/* read */
 	apr_bucket_read(pbktIn,&data,&len,APR_BLOCK_READ);
 
 	/* write */
-	buf=apr_palloc(f->r->pool,len);
+	buf=malloc(len);
 	for(n=0 ; n < len ; ++n)
 	    buf[n]=toupper(data[n]);
 
-	/* XXX: should we use a heap bucket instead? Or a transient (in
-	 * which case we need a separate brigade for each bucket)?
-         */
-	pbktOut=apr_bucket_pool_create(buf,len,f->r->pool);
+	pbktOut=apr_bucket_heap_create(buf,len,0);
 	APR_BRIGADE_INSERT_TAIL(pbbOut,pbktOut);
 	}