From: Jim Warner <james.warner@comcast.net>
Date: Tue, 25 Jan 2022 06:00:00 +0000 (-0600)
Subject: top: eliminate the potential warnings '-Wsign-compare'
X-Git-Tag: v4.0.0~50
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bc8b5a06b8b22a98c0aeba596630fc60c9b0f23a;p=procps-ng

top: eliminate the potential warnings '-Wsign-compare'

Signed-off-by: Jim Warner <james.warner@comcast.net>
---

diff --git a/top/top.c b/top/top.c
index bd6ea3be..cea6b76c 100644
--- a/top/top.c
+++ b/top/top.c
@@ -92,8 +92,8 @@ static float       Cpu_pmax;
 static const char *Cpu_States_fmts;
 
         /* Specific process id monitoring support */
-static unsigned Monpids [MONPIDMAX+1] = { 0 };
-static int      Monpidsidx = 0;
+static int Monpids [MONPIDMAX+1] = { 0 };
+static int Monpidsidx = 0;
 
         /* Current screen dimensions.
            note: the number of processes displayed is tracked on a per window
@@ -2516,7 +2516,7 @@ static void *tasks_refresh (void *unused) {
       what = Thread_mode ? PIDS_FETCH_THREADS_TOO : PIDS_FETCH_TASKS_ONLY;
       if (Monpidsidx) {
          what |= PIDS_SELECT_PID;
-         Pids_reap = procps_pids_select(Pids_ctx, Monpids, Monpidsidx, what);
+         Pids_reap = procps_pids_select(Pids_ctx, (unsigned *)Monpids, Monpidsidx, what);
       } else
          Pids_reap = procps_pids_reap(Pids_ctx, what);
       if (!Pids_reap)
@@ -4463,12 +4463,12 @@ static inline int wins_usrselect (const WIN_t *q, int idx) {
       case 0:                                    // uid selection inactive
          return 1;
       case 'U':                                  // match any uid
-         if (rSv(EU_URD)     == q->usrseluid) return q->usrselflg;
-         if (rSv(EU_USD)     == q->usrseluid) return q->usrselflg;
-         if (rSv(eu_ID_FUID) == q->usrseluid) return q->usrselflg;
+         if (rSv(EU_URD)     == (unsigned)q->usrseluid) return q->usrselflg;
+         if (rSv(EU_USD)     == (unsigned)q->usrseluid) return q->usrselflg;
+         if (rSv(eu_ID_FUID) == (unsigned)q->usrseluid) return q->usrselflg;
       // fall through...
       case 'u':                                  // match effective uid
-         if (rSv(EU_UED)     == q->usrseluid) return q->usrselflg;
+         if (rSv(EU_UED)     == (unsigned)q->usrseluid) return q->usrselflg;
       // fall through...
       default:                                   // no match...
          ;