From: Antoine Pitrou <solipsis@pitrou.net>
Date: Fri, 17 Dec 2010 17:44:45 +0000 (+0000)
Subject: Merged revisions 87341 via svnmerge from
X-Git-Tag: v3.2.1b1~347^2~156
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bc7f20cea4dba44214edf5222afb18c4452f747d;p=python

Merged revisions 87341 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r87341 | antoine.pitrou | 2010-12-17 18:42:16 +0100 (ven., 17 déc. 2010) | 4 lines

  Issue #4188: Avoid creating dummy thread objects when logging operations
  from the threading module (with the internal verbose flag activated).
........
---

diff --git a/Lib/threading.py b/Lib/threading.py
index 178c8fd33c..24808d43b8 100644
--- a/Lib/threading.py
+++ b/Lib/threading.py
@@ -50,8 +50,14 @@ if __debug__:
         def _note(self, format, *args):
             if self._verbose:
                 format = format % args
-                format = "%s: %s\n" % (
-                    current_thread().name, format)
+                # Issue #4188: calling current_thread() can incur an infinite
+                # recursion if it has to create a DummyThread on the fly.
+                ident = _get_ident()
+                try:
+                    name = _active[ident].name
+                except KeyError:
+                    name = "<OS thread %d>" % ident
+                format = "%s: %s\n" % (name, format)
                 _sys.stderr.write(format)
 
 else:
diff --git a/Misc/NEWS b/Misc/NEWS
index a49b34488c..e53aff0dcb 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -20,6 +20,10 @@ Core and Builtins
 
 Library
 -------
+
+- Issue #4188: Avoid creating dummy thread objects when logging operations
+  from the threading module (with the internal verbose flag activated).
+
 - Issue #9721: Fix the behavior of urljoin when the relative url starts with a
   ';' character. Patch by Wes Chow.