From: Ted Kremenek <kremenek@apple.com>
Date: Wed, 16 Dec 2009 19:42:23 +0000 (+0000)
Subject: Remove use of ObjCObjectRegion from BasicStoreManager.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bc73b597ed395c01c2fe7229230367990cb7ebea;p=clang

Remove use of ObjCObjectRegion from BasicStoreManager.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@91553 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/BasicStore.cpp b/lib/Analysis/BasicStore.cpp
index a38aaa7eb2..237c1f9bf4 100644
--- a/lib/Analysis/BasicStore.cpp
+++ b/lib/Analysis/BasicStore.cpp
@@ -479,15 +479,11 @@ Store BasicStoreManager::getInitialStore(const LocationContext *InitLoc) {
       const Decl& CD = *InitLoc->getDecl();
       if (const ObjCMethodDecl* MD = dyn_cast<ObjCMethodDecl>(&CD)) {
         if (MD->getSelfDecl() == PD) {
-          // FIXME: Just use a symbolic region, and remove ObjCObjectRegion
-          // entirely.
-          const ObjCObjectRegion *SelfRegion =
-            MRMgr.getObjCObjectRegion(MD->getClassInterface(),
-                                      MRMgr.getHeapRegion());
-
-          St = BindInternal(St, ValMgr.makeLoc(MRMgr.getVarRegion(PD, InitLoc)),
-                            ValMgr.makeLoc(SelfRegion));
-
+          // FIXME: Add type constraints (when they become available) to
+          // SelfRegion?  (i.e., it implements MD->getClassInterface()).
+          const MemRegion *SelfRegion = MRMgr.getVarRegion(PD, InitLoc);
+          St = BindInternal(St, ValMgr.makeLoc(SelfRegion),
+                            ValMgr.getRegionValueSymbolVal(SelfRegion));
           // Scan the method for ivar references.  While this requires an
           // entire AST scan, the cost should not be high in practice.
           St = scanForIvars(MD->getBody(), PD, SelfRegion, St);