From: George Burgess IV <george.burgess.iv@gmail.com>
Date: Tue, 21 Jun 2016 01:42:47 +0000 (+0000)
Subject: [CFLAA] Be more aggressive with interprocedural analysis.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bc51bb9f2094363eb5ebcc33361c197d6115b223;p=llvm

[CFLAA] Be more aggressive with interprocedural analysis.

This patch makes us perform interprocedural analysis on functions that
don't have internal linkage. It also removes a test that should've been
deleted in an earlier commit (since other tests now cover everything
that the newly-removed test covers).

Patch by Jia Chen.

Differential Revision: http://reviews.llvm.org/D21513


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@273229 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/CFLAliasAnalysis.cpp b/lib/Analysis/CFLAliasAnalysis.cpp
index bebc61458f0..8f3c497570a 100644
--- a/lib/Analysis/CFLAliasAnalysis.cpp
+++ b/lib/Analysis/CFLAliasAnalysis.cpp
@@ -377,7 +377,7 @@ public:
   }
 
   static bool isFunctionExternal(Function *Fn) {
-    return Fn->isDeclaration() || !Fn->hasLocalLinkage();
+    return !Fn->hasExactDefinition();
   }
 
   bool tryInterproceduralAnalysis(CallSite CS,
diff --git a/test/Analysis/CFLAliasAnalysis/basic-interproc-ret.ll b/test/Analysis/CFLAliasAnalysis/basic-interproc-ret.ll
deleted file mode 100644
index d56a4552b51..00000000000
--- a/test/Analysis/CFLAliasAnalysis/basic-interproc-ret.ll
+++ /dev/null
@@ -1,26 +0,0 @@
-; This testcase ensures that CFL AA gives conservative answers on variables
-; that involve arguments.
-
-; RUN: opt < %s -cfl-aa -aa-eval -print-may-aliases -disable-output 2>&1 | FileCheck %s
-
-; CHECK:     Function: test
-; CHECK: 4 Total Alias Queries Performed
-; CHECK: 3 no alias responses
-; ^ The 1 MayAlias is due to %arg1. Sadly, we don't currently have machinery
-; in place to check whether %arg1 aliases %a, because BasicAA takes care of 
-; that for us.
-
-define i32* @test2(i32* %arg1) {
-  store i32 0, i32* %arg1
-
-  %a = alloca i32, align 4
-  ret i32* %a
-}
-
-define void @test() {
-  %a = alloca i32, align 4
-  %b = alloca i32, align 4
-  %c = call i32* @test2(i32* %a)
-
-  ret void
-}
diff --git a/test/Analysis/CFLAliasAnalysis/interproc-ret-arg.ll b/test/Analysis/CFLAliasAnalysis/interproc-ret-arg.ll
index c49662aa854..9d29f927e35 100644
--- a/test/Analysis/CFLAliasAnalysis/interproc-ret-arg.ll
+++ b/test/Analysis/CFLAliasAnalysis/interproc-ret-arg.ll
@@ -4,10 +4,6 @@
 ; RUN: opt < %s -disable-basicaa -cfl-aa -aa-eval -print-all-alias-modref-info -disable-output 2>&1 | FileCheck %s
 ; RUN: opt < %s -aa-pipeline=cfl-aa -passes=aa-eval -print-all-alias-modref-info -disable-output 2>&1 | FileCheck %s
 
-; We have to xfail this since @return_arg_callee is treated as an opaque 
-; function, and the anlysis couldn't prove that %b and %c are not aliases 
-; XFAIL: *
-
 define i32* @return_arg_callee(i32* %arg1, i32* %arg2) {
   ret i32* %arg1
 }
@@ -22,4 +18,4 @@ define void @test_return_arg() {
   %c = call i32* @return_arg_callee(i32* %a, i32* %b)
 
   ret void
-}
\ No newline at end of file
+}