From: Yaowu Xu Date: Fri, 9 Aug 2013 01:25:03 +0000 (-0700) Subject: fix unit test failure on win32 vs2008 build X-Git-Tag: v1.3.0~645^2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bc484ebf068efa424122d518743afc751fe7833a;p=libvpx fix unit test failure on win32 vs2008 build The mix use of double type and simd code caused invalid values stored in double variables, further caused unit tests to fail. The failures were only observed on x86-win32-vs9 build with vs2008. Change-Id: If0131754a3bf217a5ace303b7963e8f5162c34b5 --- diff --git a/test/dct16x16_test.cc b/test/dct16x16_test.cc index 079505475..89453bcd8 100644 --- a/test/dct16x16_test.cc +++ b/test/dct16x16_test.cc @@ -320,7 +320,7 @@ class FwdTrans16x16Test : public ::testing::TestWithParam { TEST_P(FwdTrans16x16Test, AccuracyCheck) { ACMRandom rnd(ACMRandom::DeterministicSeed()); int max_error = 0; - double total_error = 0; + int total_error = 0; const int count_test_block = 10000; for (int i = 0; i < count_test_block; ++i) { DECLARE_ALIGNED_ARRAY(16, int16_t, test_input_block, 256); diff --git a/test/fdct4x4_test.cc b/test/fdct4x4_test.cc index 9dcc0785d..39f915ca4 100644 --- a/test/fdct4x4_test.cc +++ b/test/fdct4x4_test.cc @@ -136,7 +136,7 @@ TEST_P(FwdTrans4x4Test, RoundTripErrorCheck) { ACMRandom rnd(ACMRandom::DeterministicSeed()); int max_error = 0; - double total_error = 0; + int total_error = 0; const int count_test_block = 1000000; for (int i = 0; i < count_test_block; ++i) { DECLARE_ALIGNED_ARRAY(16, int16_t, test_input_block, 16); diff --git a/test/fdct8x8_test.cc b/test/fdct8x8_test.cc index 50e2e9d4d..81d242b4d 100644 --- a/test/fdct8x8_test.cc +++ b/test/fdct8x8_test.cc @@ -148,7 +148,7 @@ TEST_P(FwdTrans8x8Test, SignBiasCheck) { TEST_P(FwdTrans8x8Test, RoundTripErrorCheck) { ACMRandom rnd(ACMRandom::DeterministicSeed()); int max_error = 0; - double total_error = 0; + int total_error = 0; const int count_test_block = 100000; for (int i = 0; i < count_test_block; ++i) { DECLARE_ALIGNED_ARRAY(16, int16_t, test_input_block, 64); @@ -199,7 +199,7 @@ TEST_P(FwdTrans8x8Test, RoundTripErrorCheck) { TEST_P(FwdTrans8x8Test, ExtremalCheck) { ACMRandom rnd(ACMRandom::DeterministicSeed()); int max_error = 0; - double total_error = 0; + int total_error = 0; const int count_test_block = 100000; for (int i = 0; i < count_test_block; ++i) { DECLARE_ALIGNED_ARRAY(16, int16_t, test_input_block, 64);