From: Craig Topper Date: Sat, 28 Oct 2017 23:10:13 +0000 (+0000) Subject: [X86] Remove invalid code from LowerVSELECT. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bc1d6a2e8750093c9a16c5de3cc94fba83c26d13;p=llvm [X86] Remove invalid code from LowerVSELECT. This code attempted to say that v8i16/v16i16 VSELECT is legal if BWI and VLX are enabled, but the only way we could reach this point is if the condition was not a vXi1 type. Which means it really wasn't legal. We don't have any tests that exercise this code. So I'm hoping it wasn't really reachable. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@316851 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Target/X86/X86ISelLowering.cpp b/lib/Target/X86/X86ISelLowering.cpp index 0b3615843a3..900c99be808 100644 --- a/lib/Target/X86/X86ISelLowering.cpp +++ b/lib/Target/X86/X86ISelLowering.cpp @@ -14232,10 +14232,6 @@ SDValue X86TargetLowering::LowerVSELECT(SDValue Op, SelectionDAG &DAG) const { case MVT::v8i16: case MVT::v16i16: - // AVX-512 BWI and VLX features support VSELECT with i16 elements. - if (Subtarget.hasBWI() && Subtarget.hasVLX()) - return Op; - // FIXME: We should custom lower this by fixing the condition and using i8 // blends. return SDValue();