From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 10 Oct 2016 14:35:58 +0000 (-0400)
Subject: In PQsendQueryStart(), avoid leaking any left-over async result.
X-Git-Tag: REL9_6_1~35
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bb211b66f2934fbfe85c091dbff8db9ac520ceb5;p=postgresql

In PQsendQueryStart(), avoid leaking any left-over async result.

Ordinarily there would not be an async result sitting around at this
point, but it appears that in corner cases there can be.  Considering
all the work we're about to launch, it's hardly going to cost anything
noticeable to check.

It's been like this forever, so back-patch to all supported branches.

Report: <CAD-Qf1eLUtBOTPXyFQGW-4eEsop31tVVdZPu4kL9pbQ6tJPO8g@mail.gmail.com>
---

diff --git a/src/interfaces/libpq/fe-exec.c b/src/interfaces/libpq/fe-exec.c
index a9ba54628f..87ff5659ff 100644
--- a/src/interfaces/libpq/fe-exec.c
+++ b/src/interfaces/libpq/fe-exec.c
@@ -1386,8 +1386,7 @@ PQsendQueryStart(PGconn *conn)
 	}
 
 	/* initialize async result-accumulation state */
-	conn->result = NULL;
-	conn->next_result = NULL;
+	pqClearAsyncResult(conn);
 
 	/* reset single-row processing mode */
 	conn->singleRowMode = false;