From: gnrunge Date: Tue, 22 Feb 2022 19:10:25 +0000 (-0800) Subject: ICU-21900 With ICU-13353 being fixed, remove code that was added to work around X-Git-Tag: cldr/2022-02-23~7 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bac48c8f9d4fe19d9e63a8f7d51261e0ac82f8a6;p=icu ICU-21900 With ICU-13353 being fixed, remove code that was added to work around ICU-13353. --- diff --git a/icu4j/main/classes/core/src/com/ibm/icu/impl/number/LongNameHandler.java b/icu4j/main/classes/core/src/com/ibm/icu/impl/number/LongNameHandler.java index 080efa5a1b5..4f5dc01254f 100644 --- a/icu4j/main/classes/core/src/com/ibm/icu/impl/number/LongNameHandler.java +++ b/icu4j/main/classes/core/src/com/ibm/icu/impl/number/LongNameHandler.java @@ -295,11 +295,6 @@ public class LongNameHandler // Continue: fall back to short } - // TODO(ICU-13353): The ICU4J fallback mechanism works differently: - // investigate? Without this code, unit tests do fail: - key.setLength(0); - key.append("unitsShort/"); - key.append(subKey); unitsBundle.getAllItemsWithFallback(key.toString(), sink); } @@ -455,11 +450,6 @@ public class LongNameHandler } } - // TODO(icu-units#28): this code is not exercised by unit tests yet. - // Also, what's the fallback mechanism mentioned in ICU-13353? - key.setLength(0); - key.append("unitsShort/compound/"); - key.append(compoundKey); try { return resource.getStringWithFallback(key.toString()); } catch (MissingResourceException e) {