From: Antony Dovgal <tony2001@php.net>
Date: Wed, 12 Apr 2006 13:37:51 +0000 (+0000)
Subject: fix #37055 (incorrect reference counting for persistent OCI8 connections)
X-Git-Tag: php-5.1.3RC3~41
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=bac1fda3366198846d36cc8eae5b0ab1058bc45d;p=php

fix #37055 (incorrect reference counting for persistent OCI8 connections)
---

diff --git a/NEWS b/NEWS
index d05ec59ad0..2a3ebe45c0 100644
--- a/NEWS
+++ b/NEWS
@@ -1,6 +1,8 @@
 PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? Apr 2006, PHP 5.1.3
+- Fixed bug #37055 (incorrect reference counting for persistent OCI8 
+  connections). (Tony)
 - Fixed bug #37053 (html_errors with internal classes produces wrong links). 
   (Tony)
 - Fixed bug #37046 (foreach breaks static scope). (Dmitry)
diff --git a/ext/oci8/oci8.c b/ext/oci8/oci8.c
index cfa5a82197..868c40c482 100644
--- a/ext/oci8/oci8.c
+++ b/ext/oci8/oci8.c
@@ -1056,7 +1056,7 @@ php_oci_connection *php_oci_do_connect_ex(char *username, int username_len, char
 							/* okay, the connection is open and the server is still alive */
 							connection->used_this_request = 1;
 							smart_str_free_ex(&hashed_details, 0);
-							connection->rsrc_id = zend_list_insert(connection, le_pconnection);
+							zend_list_addref(connection->rsrc_id);
 							return connection;
 						}
 					}