From: Philip Reames <listmail@philipreames.com>
Date: Wed, 13 Mar 2019 03:17:58 +0000 (+0000)
Subject: [Tests] Expand implicit null check coverage
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=babf76c30d121d8216d29b146bc2e4bd9ad10131;p=llvm

[Tests] Expand implicit null check coverage



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@356004 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/test/CodeGen/X86/implicit-null-check.ll b/test/CodeGen/X86/implicit-null-check.ll
index 7955b183e80..4e6d67ae913 100644
--- a/test/CodeGen/X86/implicit-null-check.ll
+++ b/test/CodeGen/X86/implicit-null-check.ll
@@ -100,15 +100,73 @@ define i32 @imp_null_check_volatile_load(i32* %x) {
 }
 
 
+define i8 @imp_null_check_load_i8(i8* %x) {
+; CHECK-LABEL: imp_null_check_load_i8:
+; CHECK:       ## %bb.0: ## %entry
+; CHECK-NEXT:  Ltmp1:
+; CHECK-NEXT:    movb (%rdi), %al ## on-fault: LBB4_1
+; CHECK-NEXT:  ## %bb.2: ## %not_null
+; CHECK-NEXT:    retq
+; CHECK-NEXT:  LBB4_1: ## %is_null
+; CHECK-NEXT:    movb $42, %al
+; CHECK-NEXT:    retq
+
+ entry:
+  %c = icmp eq i8* %x, null
+  br i1 %c, label %is_null, label %not_null, !make.implicit !0
+
+ is_null:
+  ret i8 42
+
+ not_null:
+  %t = load i8, i8* %x
+  ret i8 %t
+}
+
+define i256 @imp_null_check_load_i256(i256* %x) {
+; CHECK-LABEL: imp_null_check_load_i256:
+; CHECK:       ## %bb.0: ## %entry
+; CHECK-NEXT:    movq %rdi, %rax
+; CHECK-NEXT:  Ltmp2:
+; CHECK-NEXT:    movq (%rsi), %rcx ## on-fault: LBB5_1
+; CHECK-NEXT:  ## %bb.2: ## %not_null
+; CHECK-NEXT:    movq 8(%rsi), %rdx
+; CHECK-NEXT:    movq 16(%rsi), %rdi
+; CHECK-NEXT:    movq 24(%rsi), %rsi
+; CHECK-NEXT:    movq %rsi, 24(%rax)
+; CHECK-NEXT:    movq %rdi, 16(%rax)
+; CHECK-NEXT:    movq %rdx, 8(%rax)
+; CHECK-NEXT:    movq %rcx, (%rax)
+; CHECK-NEXT:    retq
+; CHECK-NEXT:  LBB5_1: ## %is_null
+; CHECK-NEXT:    movq $0, 24(%rax)
+; CHECK-NEXT:    movq $0, 16(%rax)
+; CHECK-NEXT:    movq $0, 8(%rax)
+; CHECK-NEXT:    movq $42, (%rax)
+; CHECK-NEXT:    retq
+
+ entry:
+  %c = icmp eq i256* %x, null
+  br i1 %c, label %is_null, label %not_null, !make.implicit !0
+
+ is_null:
+  ret i256 42
+
+ not_null:
+  %t = load i256, i256* %x
+  ret i256 %t
+}
+
+
 
 define i32 @imp_null_check_gep_load(i32* %x) {
 ; CHECK-LABEL: imp_null_check_gep_load:
 ; CHECK:       ## %bb.0: ## %entry
-; CHECK-NEXT:  Ltmp1:
-; CHECK-NEXT:    movl 128(%rdi), %eax ## on-fault: LBB4_1
+; CHECK-NEXT:  Ltmp3:
+; CHECK-NEXT:    movl 128(%rdi), %eax ## on-fault: LBB6_1
 ; CHECK-NEXT:  ## %bb.2: ## %not_null
 ; CHECK-NEXT:    retq
-; CHECK-NEXT:  LBB4_1: ## %is_null
+; CHECK-NEXT:  LBB6_1: ## %is_null
 ; CHECK-NEXT:    movl $42, %eax
 ; CHECK-NEXT:    retq
 
@@ -128,12 +186,12 @@ define i32 @imp_null_check_gep_load(i32* %x) {
 define i32 @imp_null_check_add_result(i32* %x, i32 %p) {
 ; CHECK-LABEL: imp_null_check_add_result:
 ; CHECK:       ## %bb.0: ## %entry
-; CHECK-NEXT:  Ltmp2:
-; CHECK-NEXT:    addl (%rdi), %esi ## on-fault: LBB5_1
+; CHECK-NEXT:  Ltmp4:
+; CHECK-NEXT:    addl (%rdi), %esi ## on-fault: LBB7_1
 ; CHECK-NEXT:  ## %bb.2: ## %not_null
 ; CHECK-NEXT:    movl %esi, %eax
 ; CHECK-NEXT:    retq
-; CHECK-NEXT:  LBB5_1: ## %is_null
+; CHECK-NEXT:  LBB7_1: ## %is_null
 ; CHECK-NEXT:    movl $42, %eax
 ; CHECK-NEXT:    retq
 
@@ -150,16 +208,147 @@ define i32 @imp_null_check_add_result(i32* %x, i32 %p) {
   ret i32 %p1
 }
 
+define i32 @imp_null_check_sub_result(i32* %x, i32 %p) {
+; CHECK-LABEL: imp_null_check_sub_result:
+; CHECK:       ## %bb.0: ## %entry
+; CHECK-NEXT:  Ltmp5:
+; CHECK-NEXT:    movl (%rdi), %eax ## on-fault: LBB8_1
+; CHECK-NEXT:  ## %bb.2: ## %not_null
+; CHECK-NEXT:    subl %esi, %eax
+; CHECK-NEXT:    retq
+; CHECK-NEXT:  LBB8_1: ## %is_null
+; CHECK-NEXT:    movl $42, %eax
+; CHECK-NEXT:    retq
+
+ entry:
+  %c = icmp eq i32* %x, null
+  br i1 %c, label %is_null, label %not_null, !make.implicit !0
+
+ is_null:
+  ret i32 42
+
+ not_null:
+  %t = load i32, i32* %x
+  %p1 = sub i32 %t, %p
+  ret i32 %p1
+}
+
+define i32 @imp_null_check_mul_result(i32* %x, i32 %p) {
+; CHECK-LABEL: imp_null_check_mul_result:
+; CHECK:       ## %bb.0: ## %entry
+; CHECK-NEXT:  Ltmp6:
+; CHECK-NEXT:    imull (%rdi), %esi ## on-fault: LBB9_1
+; CHECK-NEXT:  ## %bb.2: ## %not_null
+; CHECK-NEXT:    movl %esi, %eax
+; CHECK-NEXT:    retq
+; CHECK-NEXT:  LBB9_1: ## %is_null
+; CHECK-NEXT:    movl $42, %eax
+; CHECK-NEXT:    retq
+
+ entry:
+  %c = icmp eq i32* %x, null
+  br i1 %c, label %is_null, label %not_null, !make.implicit !0
+
+ is_null:
+  ret i32 42
+
+ not_null:
+  %t = load i32, i32* %x
+  %p1 = mul i32 %t, %p
+  ret i32 %p1
+}
+
+define i32 @imp_null_check_udiv_result(i32* %x, i32 %p) {
+; CHECK-LABEL: imp_null_check_udiv_result:
+; CHECK:       ## %bb.0: ## %entry
+; CHECK-NEXT:  Ltmp7:
+; CHECK-NEXT:    movl (%rdi), %eax ## on-fault: LBB10_1
+; CHECK-NEXT:  ## %bb.2: ## %not_null
+; CHECK-NEXT:    xorl %edx, %edx
+; CHECK-NEXT:    divl %esi
+; CHECK-NEXT:    retq
+; CHECK-NEXT:  LBB10_1: ## %is_null
+; CHECK-NEXT:    movl $42, %eax
+; CHECK-NEXT:    retq
+
+ entry:
+  %c = icmp eq i32* %x, null
+  br i1 %c, label %is_null, label %not_null, !make.implicit !0
+
+ is_null:
+  ret i32 42
+
+ not_null:
+  %t = load i32, i32* %x
+  %p1 = udiv i32 %t, %p
+  ret i32 %p1
+}
+
+define i32 @imp_null_check_shl_result(i32* %x, i32 %p) {
+; CHECK-LABEL: imp_null_check_shl_result:
+; CHECK:       ## %bb.0: ## %entry
+; CHECK-NEXT:  Ltmp8:
+; CHECK-NEXT:    movl (%rdi), %eax ## on-fault: LBB11_1
+; CHECK-NEXT:  ## %bb.2: ## %not_null
+; CHECK-NEXT:    movl %esi, %ecx
+; CHECK-NEXT:    shll %cl, %eax
+; CHECK-NEXT:    retq
+; CHECK-NEXT:  LBB11_1: ## %is_null
+; CHECK-NEXT:    movl $42, %eax
+; CHECK-NEXT:    retq
+
+ entry:
+  %c = icmp eq i32* %x, null
+  br i1 %c, label %is_null, label %not_null, !make.implicit !0
+
+ is_null:
+  ret i32 42
+
+ not_null:
+  %t = load i32, i32* %x
+  %p1 = shl i32 %t, %p
+  ret i32 %p1
+}
+
+define i32 @imp_null_check_lshr_result(i32* %x, i32 %p) {
+; CHECK-LABEL: imp_null_check_lshr_result:
+; CHECK:       ## %bb.0: ## %entry
+; CHECK-NEXT:  Ltmp9:
+; CHECK-NEXT:    movl (%rdi), %eax ## on-fault: LBB12_1
+; CHECK-NEXT:  ## %bb.2: ## %not_null
+; CHECK-NEXT:    movl %esi, %ecx
+; CHECK-NEXT:    shrl %cl, %eax
+; CHECK-NEXT:    retq
+; CHECK-NEXT:  LBB12_1: ## %is_null
+; CHECK-NEXT:    movl $42, %eax
+; CHECK-NEXT:    retq
+
+ entry:
+  %c = icmp eq i32* %x, null
+  br i1 %c, label %is_null, label %not_null, !make.implicit !0
+
+ is_null:
+  ret i32 42
+
+ not_null:
+  %t = load i32, i32* %x
+  %p1 = lshr i32 %t, %p
+  ret i32 %p1
+}
+
+
+
+
 define i32 @imp_null_check_hoist_over_unrelated_load(i32* %x, i32* %y, i32* %z) {
 ; CHECK-LABEL: imp_null_check_hoist_over_unrelated_load:
 ; CHECK:       ## %bb.0: ## %entry
-; CHECK-NEXT:  Ltmp3:
-; CHECK-NEXT:    movl (%rdi), %eax ## on-fault: LBB6_1
+; CHECK-NEXT:  Ltmp10:
+; CHECK-NEXT:    movl (%rdi), %eax ## on-fault: LBB13_1
 ; CHECK-NEXT:  ## %bb.2: ## %not_null
 ; CHECK-NEXT:    movl (%rsi), %ecx
 ; CHECK-NEXT:    movl %ecx, (%rdx)
 ; CHECK-NEXT:    retq
-; CHECK-NEXT:  LBB6_1: ## %is_null
+; CHECK-NEXT:  LBB13_1: ## %is_null
 ; CHECK-NEXT:    movl $42, %eax
 ; CHECK-NEXT:    retq
 
@@ -180,17 +369,17 @@ define i32 @imp_null_check_hoist_over_unrelated_load(i32* %x, i32* %y, i32* %z)
 define i32 @imp_null_check_via_mem_comparision(i32* %x, i32 %val) {
 ; CHECK-LABEL: imp_null_check_via_mem_comparision:
 ; CHECK:       ## %bb.0: ## %entry
-; CHECK-NEXT:  Ltmp4:
-; CHECK-NEXT:    cmpl %esi, 4(%rdi) ## on-fault: LBB7_3
+; CHECK-NEXT:  Ltmp11:
+; CHECK-NEXT:    cmpl %esi, 4(%rdi) ## on-fault: LBB14_3
 ; CHECK-NEXT:  ## %bb.1: ## %not_null
-; CHECK-NEXT:    jge LBB7_2
+; CHECK-NEXT:    jge LBB14_2
 ; CHECK-NEXT:  ## %bb.4: ## %ret_100
 ; CHECK-NEXT:    movl $100, %eax
 ; CHECK-NEXT:    retq
-; CHECK-NEXT:  LBB7_3: ## %is_null
+; CHECK-NEXT:  LBB14_3: ## %is_null
 ; CHECK-NEXT:    movl $42, %eax
 ; CHECK-NEXT:    retq
-; CHECK-NEXT:  LBB7_2: ## %ret_200
+; CHECK-NEXT:  LBB14_2: ## %ret_200
 ; CHECK-NEXT:    movl $200, %eax
 ; CHECK-NEXT:    retq
 
@@ -218,13 +407,13 @@ define i32 @imp_null_check_gep_load_with_use_dep(i32* %x, i32 %a) {
 ; CHECK-LABEL: imp_null_check_gep_load_with_use_dep:
 ; CHECK:       ## %bb.0: ## %entry
 ; CHECK-NEXT:    ## kill: def $esi killed $esi def $rsi
-; CHECK-NEXT:  Ltmp5:
-; CHECK-NEXT:    movl (%rdi), %eax ## on-fault: LBB8_1
+; CHECK-NEXT:  Ltmp12:
+; CHECK-NEXT:    movl (%rdi), %eax ## on-fault: LBB15_1
 ; CHECK-NEXT:  ## %bb.2: ## %not_null
 ; CHECK-NEXT:    addl %edi, %esi
 ; CHECK-NEXT:    leal 4(%rax,%rsi), %eax
 ; CHECK-NEXT:    retq
-; CHECK-NEXT:  LBB8_1: ## %is_null
+; CHECK-NEXT:  LBB15_1: ## %is_null
 ; CHECK-NEXT:    movl $42, %eax
 ; CHECK-NEXT:    retq
 
@@ -247,11 +436,11 @@ define i32 @imp_null_check_gep_load_with_use_dep(i32* %x, i32 %a) {
 define void @imp_null_check_store(i32* %x) {
 ; CHECK-LABEL: imp_null_check_store:
 ; CHECK:       ## %bb.0: ## %entry
-; CHECK-NEXT:  Ltmp6:
-; CHECK-NEXT:    movl $1, (%rdi) ## on-fault: LBB9_1
+; CHECK-NEXT:  Ltmp13:
+; CHECK-NEXT:    movl $1, (%rdi) ## on-fault: LBB16_1
 ; CHECK-NEXT:  ## %bb.2: ## %not_null
 ; CHECK-NEXT:    retq
-; CHECK-NEXT:  LBB9_1: ## %is_null
+; CHECK-NEXT:  LBB16_1: ## %is_null
 ; CHECK-NEXT:    retq
 
  entry:
@@ -271,11 +460,11 @@ define void @imp_null_check_unordered_store(i32* %x) {
 ; CHECK-LABEL: imp_null_check_unordered_store:
 ; CHECK:       ## %bb.0: ## %entry
 ; CHECK-NEXT:    testq %rdi, %rdi
-; CHECK-NEXT:    je LBB10_1
+; CHECK-NEXT:    je LBB17_1
 ; CHECK-NEXT:  ## %bb.2: ## %not_null
 ; CHECK-NEXT:    movl $1, (%rdi)
 ; CHECK-NEXT:    retq
-; CHECK-NEXT:  LBB10_1: ## %is_null
+; CHECK-NEXT:  LBB17_1: ## %is_null
 ; CHECK-NEXT:    retq
 
  entry:
@@ -293,11 +482,11 @@ define void @imp_null_check_unordered_store(i32* %x) {
 define i32 @imp_null_check_neg_gep_load(i32* %x) {
 ; CHECK-LABEL: imp_null_check_neg_gep_load:
 ; CHECK:       ## %bb.0: ## %entry
-; CHECK-NEXT:  Ltmp7:
-; CHECK-NEXT:    movl -128(%rdi), %eax ## on-fault: LBB11_1
+; CHECK-NEXT:  Ltmp14:
+; CHECK-NEXT:    movl -128(%rdi), %eax ## on-fault: LBB18_1
 ; CHECK-NEXT:  ## %bb.2: ## %not_null
 ; CHECK-NEXT:    retq
-; CHECK-NEXT:  LBB11_1: ## %is_null
+; CHECK-NEXT:  LBB18_1: ## %is_null
 ; CHECK-NEXT:    movl $42, %eax
 ; CHECK-NEXT:    retq