From: nhmall Date: Sat, 16 Oct 2021 14:16:13 +0000 (-0400) Subject: out-of-bounds access in farlook pr592 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ba64bb8ce2fcff03e519449363087ff682fb644a;p=nethack out-of-bounds access in farlook pr592 https://github.com/NetHack/NetHack/pull/592 comment states: "In commit db68395, most of the instances of xdir and ydir here were changed to u.dx and u.dy, but not all of them. The remaining ones are out-of-bounds on xdir and ydir, because i is always set to 12 from an earlier loop and is no longer involved in handling user input. They should be u.dx and u.dy like the rest." --- diff --git a/doc/fixes37.0 b/doc/fixes37.0 index 76b2a48ed..5dcb5bf87 100644 --- a/doc/fixes37.0 +++ b/doc/fixes37.0 @@ -1295,8 +1295,8 @@ permit blind feeling for objects on trap door and fix up msgs when dropping travel from 'interesting position' (pr #575 by entrez) running on ice sent hero in weird directions (pr #588 by copperwater) delete extra lines in Guidebook.mn (pr #590 by argrath) -Supply missing changes on Guidebook.tex (pr #591 by argrath) - +supply missing changes on Guidebook.tex (pr #591 by argrath) +fix out-of-bounds access of xdir and ydir in farlook (pr #592 by copperwater) Code Cleanup and Reorganization